Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested network list is instantly closed after selection (click) and improve selection (#23079) #27614

Closed
Pavneet-Sing opened this issue Jan 3, 2023 · 1 comment
Closed

Nested network list is instantly closed after selection (click) and improve selection (#23079) #27614

Pavneet-Sing opened this issue Jan 3, 2023 · 1 comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality
Milestone
Closed / Dupe / I...

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jan 3, 2023 •
edited
Loading

Description

Can be fixed via tracking previously expanded list of networks or by optimising the unwanted list refresh event.

Actual result

Screencast.from.03-01-23.04.43.02.PM.IST.webm

Expected result

Nested list should stay open after click until the selection screen is closed
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 3, 2023
@Pavneet-Sing Pavneet-Sing added this to Web3 Jan 3, 2023
@Pavneet-Sing Pavneet-Sing changed the title Nested network list is instantly closed after selection (click) Nested network list is instantly closed after selection (click) and improve selection (#23079) Jan 5, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 6, 2023
Merged
25 tasks
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Jan 6, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jan 6, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 15, 2023
Closed
25 tasks
@Pavneet-Sing
Copy link
Author

Closing: No longer applicable with flat network list brave/brave-core#19467

@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Aug 1, 2023
@Pavneet-Sing Pavneet-Sing removed priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes labels Aug 1, 2023
@Pavneet-Sing Pavneet-Sing added this to the Closed / Dupe / Invalid milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality
Projects
Web3
Archived in project
Milestone
Closed / Dupe / Invalid
Development

Successfully merging a pull request may close this issue.

feat(wallet): Implemented show all networks assets brave/brave-core
2 participants
@jamesmudgett @Pavneet-Sing