Revert changes to Extensions page strings. #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS due to localization issues. - Updates extensions web UI page to use the default Chromium string instead of the removed IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS. - Reverts patch that made those strings accessible to the web UI. - Includes updated .grd[p] files resulting from running chromium_rebase_l10n as a part of fix for brave/brave-browser#2983. Fixes brave/brave-browser#2982 Fixes brave/brave-browser#2983
bridiver
reviewed
Jan 17, 2019
| @@ -10,7 +10,7 @@ index 90244de120cf8fda71002f535810619b1e8aeb3e..84450aca34abf7b55e1289b8716b81d5 | |||
| + hidden$="[[shouldShowEmptyItemsMessage_( | |||
There was a problem hiding this comment.
can we create a template for this so it's just a single line patch? See chrome/browser/resources/md_bookmarks/item.html / chrome/browser/resources/md_bookmarks/list.html
There was a problem hiding this comment.
I don't think this was added here
There was a problem hiding this comment.
I will make a separate issue to address this.
There was a problem hiding this comment.
yep, I guess it's just a change to the existing patch, but we should try to clean this stuff up when it comes up. Follow-up issue works for me
bbondy
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#2982
Fixes brave/brave-browser#2983
Uplift request from #1358