Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes to Extensions page strings #2982

Closed
mkarolin opened this issue Jan 16, 2019 · 2 comments · Fixed by brave/brave-core#1358
Closed

Revert changes to Extensions page strings #2982

mkarolin opened this issue Jan 16, 2019 · 2 comments · Fixed by brave/brave-core#1358
Assignees
@mkarolin
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@mkarolin
Copy link
Contributor

Due to localization issues with string containing tags brave/brave-core#1080, which fixed #1013 and #2497, needs to be reverted.
@mkarolin mkarolin self-assigned this Jan 16, 2019
This was referenced Jan 16, 2019
Closed
Merged
@mkarolin
Copy link
Contributor Author

Clarification: on Extensions page phrases You don't have any extensions yet. Would you like to [install some]? (when you have no extensions installed) and Looking for even more extensions? (when you have installed extensions) will revert to Find extensions and themes in the [Web Store] in both cases.

mkarolin added a commit to brave/brave-core that referenced this issue Jan 16, 2019
@mkarolin
- Removes IDS_MD_EXTENSIONS_BRAVE_NO_INSTALLED_ITEMS and
d862921 
IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS due to localization issues.
- Updates extensions web UI page to use the default Chromium string
instead of the removed IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS.
- Reverts patch that made those strings accessible to the web UI.
- Includes updated .grd[p] files resulting from running
chromium_rebase_l10n as a part of fix for brave/brave-browser#2983.

Fixes brave/brave-browser#2982
Fixes brave/brave-browser#2983
mkarolin added a commit to brave/brave-core that referenced this issue Jan 16, 2019
@mkarolin
- Removes IDS_MD_EXTENSIONS_BRAVE_NO_INSTALLED_ITEMS and
973e1bb 
IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS due to localization issues.
- Updates extensions web UI page to use the default Chromium string
instead of the removed IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS.
- Reverts patch that made those strings accessible to the web UI.
- Includes updated .grd[p] files resulting from running
chromium_rebase_l10n as a part of fix for brave/brave-browser#2983.

Fixes brave/brave-browser#2982
Fixes brave/brave-browser#2983
@mkarolin mkarolin mentioned this issue Jan 16, 2019
Merged
mkarolin added a commit to brave/brave-core that referenced this issue Jan 16, 2019
@mkarolin
- Removes IDS_MD_EXTENSIONS_BRAVE_NO_INSTALLED_ITEMS and
422f88b 
IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS due to localization issues.
- Updates extensions web UI page to use the default Chromium string
instead of the removed IDS_MD_EXTENSIONS_BRAVE_MORE_EXTENSIONS.
- Reverts patch that made those strings accessible to the web UI.
- Includes updated .grd[p] files resulting from running
chromium_rebase_l10n as a part of fix for brave/brave-browser#2983.

Fixes brave/brave-browser#2982
Fixes brave/brave-browser#2983
@mkarolin mkarolin mentioned this issue Jan 16, 2019
Merged
@mkarolin mkarolin added this to the 0.59.x - Beta milestone Jan 17, 2019
@btlechowski
Copy link

btlechowski commented Jan 21, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows 7

Used test plan from brave/brave-core#1358

image
image

Verification passed on

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

screen shot 2019-01-23 at 4 24 28 pm

screen shot 2019-01-23 at 4 24 35 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Revert changes to Extensions page strings. brave/brave-core
5 participants
@kjozwiak @rebron @srirambv @btlechowski @mkarolin