Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly patch Web Store link in brave://extensions #3012

Closed
mkarolin opened this issue Jan 17, 2019 · 1 comment · Fixed by brave/brave-core#1615
Closed

Properly patch Web Store link in brave://extensions #3012

mkarolin opened this issue Jan 17, 2019 · 1 comment · Fixed by brave/brave-core#1615
Assignees
@mkarolin
Labels
dev-concern QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.63.x - Release ...

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jan 17, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1615

Description

As @bridiver commented brave/brave-core#1364 (comment) this change needs to be externalized to simplify patching.
@mkarolin mkarolin self-assigned this Jan 17, 2019
@rebron rebron added this to the 1.x Backlog milestone Jan 18, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@mkarolin mkarolin mentioned this issue Feb 7, 2019
Merged
18 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Feb 9, 2019
@mkarolin
Externalize HTML/JS changes to extensions item_list.html/js.
a59dfdb 
- Adds brave_extensions_resources.pak

Fixes brave/brave-browser#3012
mkarolin added a commit to brave/brave-core that referenced this issue Feb 26, 2019
@mkarolin
Externalize HTML/JS changes to extensions item_list.html/js.
7a3a54f 
- Adds brave_extensions_resources.pak

Fixes brave/brave-browser#3012
@bsclifton bsclifton added this to the 0.63.x - Nightly milestone Feb 28, 2019
@bsclifton bsclifton changed the title Extensions item_list.html patch needs to externalize changes. Properly patch Web Store link in extension Feb 28, 2019
@bsclifton bsclifton changed the title Properly patch Web Store link in extension Properly patch Web Store link in brave://extensions Feb 28, 2019
@mkarolin mkarolin mentioned this issue Feb 28, 2019
Closed
@btlechowski
Copy link

btlechowski commented Mar 13, 2019 •
edited
Loading

Verification passed on

Brave 0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1615

image
image
image

Verified passed with

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Ubuntu 18.04 LTS

Used test plan from brave/brave-core#1615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
dev-concern QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Externalize HTML/JS changes to extensions item_list.html/js. brave/brave-core
5 participants
@bsclifton @rebron @LaurenWags @btlechowski @mkarolin