Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Danish localization #7220

Merged
merged 19 commits into from
Jan 24, 2025
Merged

Add Danish localization #7220

merged 19 commits into from
Jan 24, 2025

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Dec 20, 2024

Add translation for Danish (da).

Demo site: https://bsky.aggemam.dk

@c960657 c960657 mentioned this pull request Dec 20, 2024
Closed
@c960657 c960657 mentioned this pull request Dec 22, 2024
Merged
@pfrazee
Copy link
Collaborator

pfrazee commented Dec 31, 2024

Awesome, thank you @c960657 ! If you could get one other danish speaker to review this, I can get it merged!

simonschultz
simonschultz reviewed Jan 1, 2025
View reviewed changes
Copy link

@simonschultz simonschultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good !!!

enotoe
enotoe reviewed Jan 2, 2025
View reviewed changes
Copy link

@enotoe enotoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical error in line messages.po#L8266

enotoe
enotoe reviewed Jan 2, 2025
View reviewed changes
Copy link

@enotoe enotoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error in navbar.

Screenshot_20250102_014704_Firefox

auroursa
auroursa reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@auroursa auroursa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this causing the navbar issue.

src/locale/locales/da/messages.po Outdated Show resolved Hide resolved
c960657 and others added 2 commits January 2, 2025 10:24
@c960657 @auroursa
Update src/locale/locales/da/messages.po
4e168fa 
Co-authored-by: Frudrax Cheng <i@cynosura.one>
@c960657
Typo
dd0f5a0
@c960657
Copy link
Contributor Author

c960657 commented Jan 2, 2025

Thanks for the reviews. The stray quote in the navbar and the error in line 8266 have been fixed now.

@c960657
Copy link
Contributor Author

c960657 commented Jan 2, 2025 •
edited
Loading

There is a suggestion here about translating “post” to “indlæg” or “opslag” (instead of just using the English term) and “repost” to “videredel”/“videredeling”. I tend to agree.

https://bsky.aggemam.dk/profile/esben.leonhard-frederiksen.dk/post/3leqwinep6224

enotoe
enotoe reviewed Jan 2, 2025
View reviewed changes
Copy link

@enotoe enotoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

surfdude29
surfdude29 reviewed Jan 2, 2025
View reviewed changes
lingui.config.js Outdated Show resolved Hide resolved
@surfdude29

This comment was marked as resolved.

Sign in to view
@kseistrup
Copy link

I've corrected a few typos. Please see attached diff:

📎 rettelser-diff.txt

Looks good otherwise.

@emilstahl
Copy link

LGTM 👍

@c960657
Copy link
Contributor Author

c960657 commented Jan 15, 2025

The dust has settled on this PR now, and I think it is ready to be merged.

I have addressed all issues raised here and in the Bluesky thread linked above, and I don't think there are any strong disagreements.

@pfrazee
Copy link
Collaborator

pfrazee commented Jan 24, 2025

Awesome, tsym all!

@pfrazee pfrazee merged commit 68c4737 into bluesky-social:main Jan 24, 2025
@surfdude29
Copy link
Contributor

In case it's helpful to know, the new Danish localization can be tried out on the dev server at: main.bsky.dev

This is what the @bsky.app profile looks like for instance:

IMG_0456

If you see anything that should be changed before the 1.97 release is cut, a new PR can be submitted in the next 24 hours or so and then it should make it into the release, as described here:

@c960657 c960657 deleted the locale-da branch January 24, 2025 23:28
@c960657 c960657 mentioned this pull request Jan 25, 2025
Merged
estrattonbailey added a commit that referenced this pull request Feb 5, 2025
@estrattonbailey
Merge remote-tracking branch 'origin/main' into next/base
2583c17 
* origin/main: (100 commits)
  Adding webp to regex list. Added function return type for consistency with the rest of the functions (#7649)
  bump version (#7650)
  use did for userID (#7647)
  Upgrade RN to 0.76.6 (#7557)
  Update expo-blur (#7596)
  Fix slow Hosting Provider dialog (#7594)
  make convo menu lazy (#7604)
  Fix convo header loading state (#7603)
  Spring cleaning (#7640)
  Date input improvements (#7639)
  Add example account store (#7641)
  rm refs in render (#7589)
  change search cancel behaviour (#7624)
  reduce padding on video overlay (#7617)
  Typo fix (#7637)
  no follow self (#7606)
  env var tweaks (#7457)
  Test fix
  Add Danish localization (#7220)
  Add Swedish localization (#7232)
  ...
@c960657 c960657 mentioned this pull request Feb 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renejsum renejsum renejsum left review comments

@simonschultz simonschultz simonschultz left review comments

@enotoe enotoe enotoe left review comments

@auroursa auroursa auroursa left review comments

@surfdude29 surfdude29 surfdude29 left review comments

@pfrazee pfrazee pfrazee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@c960657 @pfrazee @surfdude29 @kseistrup @emilstahl @renejsum @simonschultz @enotoe @auroursa