Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24759 - Update Alteration Warning Language #604

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

ArwenQin
Copy link
Collaborator

Issue #: /bcgov/entity#24759
Description of changes:

  • Update the language in "Change company name" warning

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin ArwenQin self-assigned this Dec 16, 2024
@ArwenQin
Copy link
Collaborator Author

After update:
image

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
devops/vaults.env Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
Copy link
Collaborator

@AimeeGao AimeeGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from Sev's comments, everything looks good to me (^-^)

Copy link
Collaborator

@meawong meawong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM! Approved once Sev's comments are addressed.

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin
Copy link
Collaborator Author

Added a new icon, per updated design:
image

target="_blank"
rel="noopener"
>
Name Request
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open in a new tab. Does this method look ok?

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>
@ArwenQin
Copy link
Collaborator Author

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre Dec 17, 2024
@bcgov bcgov deleted a comment from bcregistry-sre Dec 17, 2024
@bcgov bcgov deleted a comment from bcregistry-sre Dec 17, 2024
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-604-kq7m7io7.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all-good to me.

@ArwenQin ArwenQin merged commit 0367648 into bcgov:main Dec 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants