Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24759 - Update Alteration Warning Language #604

Merged
merged 5 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ VUE_APP_REGISTRY_HOME_URL="https://dev.bcregistry.gov.bc.ca/"
VUE_APP_AUTH_WEB_URL="https://dev.account.bcregistry.gov.bc.ca/"
VUE_APP_BUSINESSES_URL="https://dev.account.bcregistry.gov.bc.ca/"
VUE_APP_DASHBOARD_URL="https://dev.business.bcregistry.gov.bc.ca/"
VUE_APP_NAME_REQUEST_URL="https://dev.names.bcregistry.gov.bc.ca/"
VUE_APP_SITEMINDER_LOGOUT_URL="https://logontest7.gov.bc.ca/clp-cgi/logoff.cgi"

#vaults API
Expand Down
3 changes: 2 additions & 1 deletion devops/vaults.env
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ VUE_APP_REGISTRY_HOME_URL="op://web-url/$APP_ENV/registry/REGISTRY_HOME_URL"
VUE_APP_AUTH_WEB_URL="op://web-url/$APP_ENV/auth-web/AUTH_WEB_URL"
VUE_APP_BUSINESSES_URL="op://web-url/$APP_ENV/business/BUSINESSES_URL"
VUE_APP_DASHBOARD_URL="op://web-url/$APP_ENV/business/DASHBOARD_URL"
VUE_APP_NAME_REQUEST_URL="op://web-url/$APP_ENV/name-request/NAME_REQUEST_URL"
VUE_APP_SITEMINDER_LOGOUT_URL="op://web-url/$APP_ENV/siteminder/SITEMINDER_LOGOUT_URL"

#vaults API
Expand Down Expand Up @@ -38,4 +39,4 @@ VUE_APP_KEYCLOAK_CLIENTID="op://keycloak/$APP_ENV/entity-web/UI_KEYCLOAK_RESOURC
VUE_APP_SENTRY_DSN="op://sentry/$APP_ENV/entity/SENTRY_DSN"

#vaults hotjar (hotjar id - ready to use)
VUE_APP_HOTJAR_ID=
VUE_APP_HOTJAR_ID=
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "4.11.11",
"version": "4.11.12",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down
19 changes: 16 additions & 3 deletions src/components/common/YourCompany/ChangeBusinessType.vue
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,21 @@
<strong class="pl-2 gray9--text text-small-text">Change company name</strong>
</header>
<article class="pl-8 pt-1 small-text">
To change to a {{ GetCorpFullDescription(selectedEntityType) }}, you must change the company
name using an approved name request or change it to a numbered company.
To change to a {{ GetCorpFullDescription(selectedEntityType) }}, you must change your company name.
You can use your incorporation number as the company name or go to
<a
:href="nameRequestUrl"
class="underline-blue-text"
target="_blank"
rel="noopener"
>
Name Request
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open in a new tab. Does this method look ok?

<v-icon
small
color="primary"
>mdi-open-in-new</v-icon>
</a>
and choose “alter from one business type to another.”
</article>
</MessageBox>

Expand Down Expand Up @@ -324,7 +337,7 @@ import MessageBox from '@/components/common/MessageBox.vue'
export default class ChangeBusinessType extends Mixins(CommonMixin) {
// for template
readonly GetCorpFullDescription = GetCorpFullDescription

readonly nameRequestUrl: string = sessionStorage.getItem('NAME_REQUEST_URL') || ''
@Prop({ default: false }) readonly invalidSection!: boolean

// Store getters
Expand Down
3 changes: 3 additions & 0 deletions src/utils/FetchConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ export async function FetchConfig (): Promise<any> {
const registryHomeUrl: string = import.meta.env.VUE_APP_REGISTRY_HOME_URL
sessionStorage.setItem('REGISTRY_HOME_URL', registryHomeUrl)

const nameRequestUrl: string = import.meta.env.VUE_APP_NAME_REQUEST_URL
sessionStorage.setItem('NAME_REQUEST_URL', nameRequestUrl)

const businessesUrl: string = import.meta.env.VUE_APP_BUSINESSES_URL
sessionStorage.setItem('BUSINESSES_URL', businessesUrl)

Expand Down
2 changes: 2 additions & 0 deletions tests/unit/FetchConfig.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ describe('Fetch Config', () => {
import.meta.env.VUE_APP_PAY_API_URL = 'pay api url'
import.meta.env.VUE_APP_PAY_API_VERSION = '/pay api version'
import.meta.env.VUE_APP_REGISTRY_HOME_URL = 'registry home url'
import.meta.env.VUE_APP_NAME_REQUEST_URL = 'name request url'
import.meta.env.VUE_APP_REGISTRIES_SEARCH_API_URL = 'registries search api url'
import.meta.env.VUE_APP_REGISTRIES_SEARCH_API_VERSION = '/registries search api version'
import.meta.env.VUE_APP_REGISTRIES_SEARCH_API_KEY = 'business api key'
Expand Down Expand Up @@ -54,6 +55,7 @@ describe('Fetch Config', () => {
expect(sessionStorage.getItem('NAICS_URL')).toBe('naics api url/naics api version/')
expect(sessionStorage.getItem('PAY_API_URL')).toBe('pay api url/pay api version/')
expect(sessionStorage.getItem('REGISTRY_HOME_URL')).toBe('registry home url')
expect(sessionStorage.getItem('NAME_REQUEST_URL')).toBe('name request url')
expect(sessionStorage.getItem('REGISTRIES_SEARCH_API_KEY')).toBe('business api key')
expect(sessionStorage.getItem('REGISTRIES_SEARCH_API_URL')).toBe('registries search api url/registries search api version/')
expect(sessionStorage.getItem('SITEMINDER_LOGOUT_URL')).toBe('siteminder logout url')
Expand Down
Loading