Use non-canonical repo name in hub repo

[cameron-martin]

#2461 changed the rendering of the hub repo to use canonical repository names, but incorrectly. Doing so wasn't necessary - instead we just need to do the resolution of the non-canonical label from the perspective of the hub repo rather than the consumer by using the Label constructor.

Fixes #2483

[UebelAndre]

Thanks! Do you know if there's something we can do to regression test this? To ensure bzlmod works in pre-commit testing?

[cameron-martin]

I couldn't immediately think of a way, since this bug only arises due to the difference in canonical repository names for overridden and non overridden repositories. I don't think there's a sensible way of getting a non-overriden repository name in tests. Open to ideas however.

[jondo2010]

I couldn't immediately think of a way, since this bug only arises due to the difference in canonical repository names for overridden and non overridden repositories. I don't think there's a sensible way of getting a non-overriden repository name in tests. Open to ideas however.

Perhaps a test workspace that pulls directly from BCR, instead of overriding to the repository rules_bazel?

[cameron-martin]

Then you can only test the latest released version, so can't catch issues before you release.

I guess you could set up a local registry, but that sounds like a lot of hassle.