Fix crate_universe when using bzlmod
#2485
Closed
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw I don't think this is the correct fix. See #2483 (comment) |
|
Withdrawing, as @cameron-martin has raised a better fix: #2491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue raised here: #2483
Now, we programmatically determine the canonical repository name prefix. This assumes that the repositories created by
crate_universewill all inherit the same prefix asrules_rust.If there is a more ideal approach to determining the canonical repository name, please suggest! I was unable to find anything else.
Additionally, I'm not sure how to code a test case against this, since we have to override the
rules_rustlocation in order to test it?