Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-canonical repo name in hub repo #2491

Merged
merged 3 commits into from
Feb 18, 2024
Merged

Use non-canonical repo name in hub repo #2491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0689c6d
Use non-canonical repo name in hub repo
cameron-martin Feb 18, 2024
f52b0fa
Merge branch 'main' into fix-2483
cameron-martin Feb 18, 2024
84aff7a
Merge branch 'main' into fix-2483
cameron-martin Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crate_universe/extension.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ def _generate_hub_and_spokes(module_ctx, cargo_bazel, cfg, annotations):

rendering_config = json.decode(render_config(
regen_command = "Run 'cargo update [--workspace]'",
crate_label_template = "@@rules_rust~override~crate~{repository}__{name}-{version}//:{target}",
))
config_file = tag_path.get_child("config.json")
module_ctx.file(
Expand Down
2 changes: 1 addition & 1 deletion crate_universe/src/rendering/templates/partials/module/deps_map.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
{%- for dep in deps_set.common %}
{%- if dep.id in context.workspace_members %}{% continue %}}{% endif %}{# Workspace member repositories are not defined, skip adding their labels here #}
{%- set crate = context.crates | get(key=dep.id) %}
"{{ dep | get(key="alias", default=crate.name) }}": "{{ crate_label(name = crate.name, version = crate.version, target = dep.target) }}",
"{{ dep | get(key="alias", default=crate.name) }}": Label("{{ crate_label(name = crate.name, version = crate.version, target = dep.target) }}"),
{%- endfor %}
},
{%- endif %}
Expand Down
Loading