Safer objc_provider assignment in apple_framework_packaging #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobmattrob
approved these changes
Mar 26, 2024
leonidmelnyk
pushed a commit
to leonidmelnyk/rules_ios
that referenced
this pull request
Apr 5, 2024
…azel-ios#855)" This reverts commit 30733da.
acecilia
pushed a commit
to revolut-mobile/rules_ios
that referenced
this pull request
Apr 5, 2024
…d libs to CcInfo linking context in Bazel 7 (#3) * Revert "Add force load libs to CcInfo linking context in Bazel 7 (#2)" This reverts commit fb395f9. * Revert "Re-add ios_multi_cpus transition setting from rules_ios (bazel-ios#856)" This reverts commit 6d6e051. * Revert "Safer objc_provider assignment in apple_framework_packaging (bazel-ios#855)" This reverts commit 30733da. * Revert "Forward package_name to swift_library part of apple_library (bazel-ios#853)" This reverts commit 3b0ca4c. * Revert "Allow consumers to set always_include_developer_search_paths in swift_library (bazel-ios#852)" This reverts commit da630a2. * Revert "Update transition support (bazel-ios#847)" This reverts commit 144eb18. * PMNG-7009 [platform] Add force load libs to CcInfo linking context in Bazel 7 --------- Co-authored-by: Leonid Melnyk <leonid.melnyk@revolut.com>
tymurmustafaiev
pushed a commit
to tymurmustafaiev/rules_ios
that referenced
this pull request
Apr 16, 2024
…azel-ios#855)" This reverts commit 30733da.
acecilia
pushed a commit
to revolut-mobile/rules_ios
that referenced
this pull request
Apr 16, 2024
…azel-ios#855)" This reverts commit 30733da.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an internal use case for us that involves passing others types of deps to
apple_framework_packagingthat might not have theapple_common.Objcprovider (cc_librarytargets). This check makes this assignment "safer" but also enables others also passing custom deps here.