Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer objc_provider assignment in apple_framework_packaging #855

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Safer objc_provider assignment in apple_framework_packaging #855

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rules/framework.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,8 +1067,8 @@ def _apple_framework_packaging_impl(ctx):
default_info = DefaultInfo(files = depset(out_files + bundle_outs.files.to_list()))

objc_provider = objc_provider_utils.merge_objc_providers(
providers = [dep[apple_common.Objc] for dep in deps],
transitive = [dep[apple_common.Objc] for dep in transitive_deps],
providers = [dep[apple_common.Objc] for dep in deps if apple_common.Objc in dep],
transitive = [dep[apple_common.Objc] for dep in transitive_deps if apple_common.Objc in dep],
)
return [
avoid_deps_info,
Expand Down