Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMNG-7009 [platform] Revert to commit before breaking + Add force load libs to CcInfo linking context in Bazel 7 #3

Merged

Conversation

leonidmelnyk
Copy link

Problem:

The compilation for the Simulator is broken: the rules_ios stopped working correctly when we passed more than one architecture with --ios_multi_cpus flag by throwing the next error

ERROR: /Users/leonid.melnyk/Developer/revolut-ios/Retail/App/Revolut/BUILD.bazel:330:4: Linking Retail/App/Revolut/RevolutApp_bin failed: (Exit 1): sandbox-exec failed: error executing ObjcLink command 
  (cd /private/var/tmp/_bazel_leonid.melnyk/216f2d84fb65a7cb614960cd8462b483/sandbox/darwin-sandbox/6493/execroot/revolut && \
  exec env - \
    APPLE_SDK_PLATFORM=iPhoneSimulator \
    APPLE_SDK_VERSION_OVERRIDE=17.2 \
    DEVELOPER_DIR=/Applications/Xcode_15.2.app/Contents/Developer \
    PATH=/bin:/usr/bin:/usr/local/bin \
    RELATIVE_AST_PATH=true \
    SDKROOT=/Applications/Xcode_15.2.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.2.sdk \
    TMPDIR=/var/folders/rv/xdqm_m_d2kg3t2_hwwh23yjm0000gq/T/ \
    XCODE_VERSION_OVERRIDE=15.2.0.15C500b \
    ZERO_AR_DATE=1 \
  /usr/bin/sandbox-exec -f /private/var/tmp/_bazel_leonid.melnyk/216f2d84fb65a7cb614960cd8462b483/sandbox/darwin-sandbox/6493/sandbox.sb /var/tmp/_bazel_leonid.melnyk/install/c235141d88c168b049a191acefbb1f54/process-wrapper '--timeout=0' '--kill_delay=15' '--stats=/private/var/tmp/_bazel_leonid.melnyk/216f2d84fb65a7cb614960cd8462b483/sandbox/darwin-sandbox/6493/stats.out' external/local_config_apple_cc/wrapped_clang @bazel-out/ios_sim_arm64-fastbuild-ios-sim_arm64-min13.0-applebin_ios-ST-d7b2f496bc41/bin/Retail/App/Revolut/RevolutApp_bin-2.params)
ld: Undefined symbols:
  _main, referenced from:
      <initial-undefines>
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Findings:

Digging the rules_ios codebase brought no result. I found the breaking commit by applying the next technique:

  • checkout a commit;
  • apply changes from this PR

Here is the PR that brought the problem.

Solution:

@acecilia acecilia merged commit d5d34b4 into revolut-mobile:master Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants