Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 돈길 컨트롤러 레이어 분리 리팩토링 #232

Closed
2 tasks done
sanbonai06 opened this issue Sep 19, 2022 · 0 comments
Closed
2 tasks done

[REFACTOR] 돈길 컨트롤러 레이어 분리 리팩토링 #232

sanbonai06 opened this issue Sep 19, 2022 · 0 comments
Assignees
@sanbonai06
Labels
For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Milestone
코드 리팩토링

Comments

@sanbonai06
Copy link
Member

sanbonai06 commented Sep 19, 2022 •
edited
Loading

🤖 기능 개요

  • 컨트롤러 레이어가 너무 무거워짐에 따라 실 컨트롤러는 응답 처리에 관한 로직만 담당하도록 리팩토링
  • 컨트롤러와 서비스 레이어를 연결해주는 Mapper 레이어를 도입하여 여러 서비스를 묶어주는 (현재의 컨트롤러 역할) 역할 담당
  • 컨트롤러 레이어는 Http 메서드 명을 따라감 (get, post, patch, put, delete)
  • 매퍼 레이어와 서비스 레이어는 crud 명을 따라감 (create, update, read, delete)
  • 매핑 DTO 정리

✅ Implement TODO

  • 응답 처리만을 담당하는 새로운 컨트롤러 레이어 도입
  • 현 컨트롤러를 Mapper로 명명

📚 Remarks

https://appleg1226.tistory.com/56
@sanbonai06 sanbonai06 added For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Sep 19, 2022
@sanbonai06 sanbonai06 added this to the 코드 리팩토링 milestone Sep 19, 2022
@sanbonai06 sanbonai06 self-assigned this Sep 19, 2022
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: 돈길 생성 API Mapper 레이어 생성하여 리팩토링 #232
03ca19f
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: 돈길 삭제 API Mapper 구조로 리팩토링 #232
90e90fb
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: 돈길 리스트 API Mapper 구조로 리팩토링 #232
1781302
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: 주차 정보 API Mapper 구조로 리팩토링 #232
087eece
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: 완주한 돈길 리스트 API Mapper 구조로 리팩토링 #232
7b1742a
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: 이자 지급 API Mapper 구조로 리팩토링 #232
e6cabdc
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: 돈길 걷기 API Mapper 구조로 리팩토링 #232
e86b66c
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: 일요일 밸리데이션 처리 추가 #232
13ab209
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
feat: 돈길 만든지 1주일 경과 전이면 삭제 조건 검사 안함 #232
b765761
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: challengeUser에 cascade가 달림에 따라 challengeUser 삭제 로직 제거 #232
f430aee
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
refactor: Transactional 처리 #232
d3fc80e
@sanbonai06 sanbonai06 mentioned this issue Sep 20, 2022
Merged
sanbonai06 added a commit that referenced this issue Sep 20, 2022
@sanbonai06
Merge pull request #233 from bankidz/refactor/facadePattern

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a248296 
refactor: 파사드 패턴을 이용하여 돈길 관련 Mapper 레이어로 리팩토링 #232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanbonai06 sanbonai06

Labels
For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
코드 리팩토링
Development

No branches or pull requests
1 participant
@sanbonai06