refactor: Transactional 처리 #232

bankidz · Sep 20, 2022 · d3fc80e · d3fc80e
1 parent f430aee
commit d3fc80e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/main/java/com/ceos/bankids/mapper/ChallengeMapper.java b/src/main/java/com/ceos/bankids/mapper/ChallengeMapper.java
@@ -39,6 +39,7 @@
 import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
 
 @Slf4j
 @Service
@@ -55,6 +56,7 @@ public class ChallengeMapper {
     private final KidServiceImpl kidService;
 
     // 돈길 생성 API Mapper
+    @Transactional
     public ChallengeDTO postChallenge(User authUser, ChallengeRequest challengeRequest) {
 
         // validation
@@ -80,6 +82,7 @@ public ChallengeDTO postChallenge(User authUser, ChallengeRequest challengeReque
     }
 
     // 돈길 삭제 API Mapper
+    @Transactional
     public ChallengeDTO deleteChallenge(User authUser, Long challengeId) {
 
         sundayValidation();
@@ -112,6 +115,7 @@ public ChallengeDTO deleteChallenge(User authUser, Long challengeId) {
     }
 
     // 돈길 리스트 가져오기 API Mapper
+    @Transactional
     public List<ChallengeDTO> getListChallenge(User authUser, String status) {
 
         userRoleValidation(authUser, true);
@@ -158,6 +162,7 @@ public List<ChallengeDTO> getListChallenge(User authUser, String status) {
     }
 
     // 자녀의 돈길 리스트 가져오기 API Mapper
+    @Transactional
     public KidChallengeListDTO getListKidChallenge(User authUser, Long kidId, String status) {
 
         userRoleValidation(authUser, false);
@@ -205,6 +210,7 @@ public KidChallengeListDTO getListKidChallenge(User authUser, Long kidId, String
     }
 
     // 돈길 수락 / 거절 API Mapper
+    @Transactional
     public ChallengeDTO patchChallengeStatus(User authUser, Long challengeId,
         KidChallengeRequest kidChallengeRequest) {
 
@@ -232,6 +238,7 @@ public ChallengeDTO patchChallengeStatus(User authUser, Long challengeId,
     }
 
     // 주차 정보 가져오기 API Mapper
+    @Transactional(readOnly = true)
     public WeekDTO getWeekInfo(User authUser) {
 
         userRoleValidation(authUser, true);
@@ -245,6 +252,7 @@ public WeekDTO getWeekInfo(User authUser) {
     }
 
     // 자녀의 주차 정보 가져오기 API Mapper
+    @Transactional(readOnly = true)
     public KidWeekDTO getKidWeekInfo(User authUser, Long kidId) {
 
         userRoleValidation(authUser, false);
@@ -262,6 +270,7 @@ public KidWeekDTO getKidWeekInfo(User authUser, Long kidId) {
     }
 
     // 완주한 돈길 리스트 가져오기 API Mapper
+    @Transactional(readOnly = true)
     public AchievedChallengeListDTO getAchievedListChallenge(User authUser,
         String interestPayment) {
 
@@ -275,6 +284,7 @@ public AchievedChallengeListDTO getAchievedListChallenge(User authUser,
     }
 
     // 자녀의 완주한 돈길 리스트 가져오기 API Mapper
+    @Transactional(readOnly = true)
     public KidAchievedChallengeListDTO getKidAchievedListChallenge(User authUser, Long kidId,
         String interestPayment) {
 
@@ -290,6 +300,7 @@ public KidAchievedChallengeListDTO getKidAchievedListChallenge(User authUser, Lo
     }
 
     // 이자 지급 API Mapper
+    @Transactional
     public AchievedChallengeDTO patchInterestPayment(User authUser, Long challengeId) {
 
         sundayValidation();
@@ -300,6 +311,7 @@ public AchievedChallengeDTO patchInterestPayment(User authUser, Long challengeId
     }
 
     // 돈길 걷기 API Mapper
+    @Transactional
     public ProgressDTO patchProgress(User authUser, Long challengeId) {
 
         sundayValidation();

diff --git a/src/main/java/com/ceos/bankids/service/ChallengeUserServiceImpl.java b/src/main/java/com/ceos/bankids/service/ChallengeUserServiceImpl.java
@@ -85,6 +85,7 @@ public void deleteAllChallengeUser(User authUser) {
         cuRepo.deleteAll(challengeUserList);
     }
 
+    @Transactional(readOnly = true)
     public void checkMaxChallengeCount(User user) {
         List<Challenge> walkingChallengeList = cuRepo.findByUserId(user.getId()).stream()
             .map(ChallengeUser::getChallenge)
@@ -95,6 +96,7 @@ public void checkMaxChallengeCount(User user) {
         }
     }
 
+    @Transactional(readOnly = true)
     public List<ChallengeUser> getChallengeUserListByContractUser(User user) {
         return cuRepo.findByChallenge_ContractUserId(user.getId());