refactor: challengeUser에 cascade가 달림에 따라 challengeUser 삭제 로직 제거 #232

bankidz · Sep 20, 2022 · f430aee · f430aee
1 parent b765761
commit f430aee
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 17 deletions.
diff --git a/src/main/java/com/ceos/bankids/mapper/ChallengeMapper.java b/src/main/java/com/ceos/bankids/mapper/ChallengeMapper.java
@@ -91,22 +91,18 @@ public ChallengeDTO deleteChallenge(User authUser, Long challengeId) {
         }
         if (deleteChallenge.getChallengeStatus() == ChallengeStatus.WALKING) {
             kidService.checkKidDeleteChallenge(authUser, deleteChallenge);
-//            challengeUserService.deleteChallengeUser(authUser, challengeId);
             return challengeService.deleteWalkingChallenge(
                 authUser,
                 challengeUser);
         } else if (deleteChallenge.getChallengeStatus() == ChallengeStatus.FAILED) {
-            challengeUserService.deleteChallengeUser(authUser, challengeId);
             return challengeService.deleteWalkingChallenge(
                 authUser,
                 challengeUser);
         } else if (deleteChallenge.getChallengeStatus() == ChallengeStatus.REJECTED) {
-            challengeUserService.deleteChallengeUser(authUser, challengeId);
             return challengeService.deleteRejectedChallenge(
                 authUser,
                 challengeUser);
         } else if (deleteChallenge.getChallengeStatus() == ChallengeStatus.PENDING) {
-            challengeUserService.deleteChallengeUser(authUser, challengeId);
             return challengeService.deletePendingChallenge(
                 authUser,
                 challengeUser);

diff --git a/src/main/java/com/ceos/bankids/service/ChallengeUserService.java b/src/main/java/com/ceos/bankids/service/ChallengeUserService.java
@@ -13,8 +13,6 @@ public interface ChallengeUserService {
 
     public ChallengeUser getChallengeUser(Long challengeId);
 
-    public void deleteChallengeUser(User authUser, Long challengeId);
-
     public List<Challenge> getChallengeUserList(User authUser, String status);
 
     public List<Challenge> getAchievedChallengeUserList(User authUser);

diff --git a/src/main/java/com/ceos/bankids/service/ChallengeUserServiceImpl.java b/src/main/java/com/ceos/bankids/service/ChallengeUserServiceImpl.java
@@ -42,17 +42,7 @@ public ChallengeUser getChallengeUser(Long challengeId) {
         return challengeUser;
     }
 
-    @Override
-    public void deleteChallengeUser(User authUser, Long challengeId) {
-        ChallengeUser deleteChallengeUser = cuRepo.findByChallengeId(challengeId).orElseThrow(
-            () -> new BadRequestException(ErrorCode.NOT_EXIST_CHALLENGE_USER.getErrorCode()));
-        if (deleteChallengeUser.getUser().getId() != authUser.getId()) {
-            throw new ForbiddenException(ErrorCode.NOT_MATCH_CHALLENGE_USER.getErrorCode());
-        }
-
-        cuRepo.delete(deleteChallengeUser);
-    }
-
+    @Transactional
     @Override
     public List<Challenge> getChallengeUserList(User authUser, String status) {
         if (Objects.equals(status, "pending")) {