fix(wrapped constructs): shorten wrapped ID names in deprecated constructs #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
requested changes
Sep 14, 2021
| // W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide | ||
| // If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate | ||
| // it in place of the older named version. They are functionally identical, aside from the types no other changes | ||
| // will be required. (eg - new EventbridgeToLambda instead of DynamoDBStreamToLambda) |
| // W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide | ||
| // If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate | ||
| // it in place of the older named version. They are functionally identical, aside from the types no other changes | ||
| // will be required. (eg - new EventbridgeToSns instead of EventsRuleToSns) | ||
| const wrappedConstruct: EventsRuleToSns = new EventbridgeToSns(this, `${id}`, convertedProps); |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #369 , if available:
Description of changes:
-Replaced
-wrappedwithWin order to prevent the error of more than 64 characters in an ID name-Updated all tests to support new id names
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
fixes #369