Skip to content

Commit

Permalink
added comments to explain new wrapped construct name
Browse files Browse the repository at this point in the history
  • Loading branch information
mickychetta committed Sep 13, 2021
1 parent 1b568aa commit 773406c
Show file tree
Hide file tree
Showing 10 changed files with 51 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ export class DynamoDBStreamToLambdaToElasticSearchAndKibana extends Construct {
constructor(scope: Construct, id: string, props: DynamoDBStreamToLambdaToElasticSearchAndKibanaProps) {
super(scope, id);
const convertedProps: DynamoDBStreamToLambdaToElasticSearchAndKibanaProps = { ...props };

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new DynamoDBStreamsToLambdaToElasticSearchAndKibana instead of DynamoDBStreamToLambdaToElasticSearchAndKibana)
const wrappedConstruct: DynamoDBStreamToLambdaToElasticSearchAndKibana = new DynamoDBStreamsToLambdaToElasticSearchAndKibana(
this, `${id}W`, convertedProps);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,12 @@ export class DynamoDBStreamToLambda extends Construct {
constructor(scope: Construct, id: string, props: DynamoDBStreamToLambdaProps) {
super(scope, id);
const convertedProps: DynamoDBStreamToLambdaProps = { ...props };
const wrappedConstruct: DynamoDBStreamToLambda = new DynamoDBStreamsToLambda(this, `${id}W`, convertedProps);

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new EventbridgeToLambda instead of DynamoDBStreamToLambda)
const wrappedConstruct: DynamoDBStreamsToLambda = new DynamoDBStreamsToLambda(this, `${id}W`, convertedProps);

this.lambdaFunction = wrappedConstruct.lambdaFunction;
this.dynamoTableInterface = wrappedConstruct.dynamoTableInterface;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ export class EventsRuleToKinesisFirehoseToS3 extends Construct {
constructor(scope: Construct, id: string, props: EventsRuleToKinesisFirehoseToS3Props) {
super(scope, id);
const convertedProps: EventsRuleToKinesisFirehoseToS3Props = { ...props };

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new EventbridgeToKinesisFirehoseToS3 instead of EventsRuleToKinesisFirehoseToS3)
const wrappedConstruct: EventsRuleToKinesisFirehoseToS3 = new EventbridgeToKinesisFirehoseToS3(this, `${id}W`, convertedProps);
this.eventsRule = wrappedConstruct.eventsRule;
this.eventsRole = wrappedConstruct.eventsRole;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ export class EventsRuleToKinesisStreams extends Construct {
constructor(scope: Construct, id: string, props: EventsRuleToKinesisStreamsProps) {
super(scope, id);
const convertedProps: EventsRuleToKinesisStreamsProps = { ...props };

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new EventbridgeToKinesisStreams instead of EventsRuleToKinesisStreams)
const wrappedConstruct: EventsRuleToKinesisStreams = new EventbridgeToKinesisStreams(this, `${id}W`, convertedProps);

this.kinesisStream = wrappedConstruct.kinesisStream;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ export class EventsRuleToLambda extends Construct {
constructor(scope: Construct, id: string, props: EventsRuleToLambdaProps) {
super(scope, id);
const convertedProps: EventsRuleToLambdaProps = { ...props };

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new EventbridgeToLambda instead of EventsRuleToLambda)
const wrappedConstruct: EventsRuleToLambda = new EventbridgeToLambda(this, `${id}W`, convertedProps);

this.lambdaFunction = wrappedConstruct.lambdaFunction;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ export class EventsRuleToSns extends Construct {
constructor(scope: Construct, id: string, props: EventsRuleToSnsProps) {
super(scope, id);
const convertedProps: EventsRuleToSnsProps = { ...props };

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new EventbridgeToSns instead of EventsRuleToSns)
const wrappedConstruct: EventsRuleToSns = new EventbridgeToSns(this, `${id}`, convertedProps);

this.snsTopic = wrappedConstruct.snsTopic;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ export class EventsRuleToSqs extends Construct {
constructor(scope: Construct, id: string, props: EventsRuleToSqsProps) {
super(scope, id);
const convertedProps: EventsRuleToSqsProps = { ...props };

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new EventbridgeToSqs instead of EventsRuleToSqs)
const wrappedConstruct: EventsRuleToSqs = new EventbridgeToSqs(this, `${id}W`, convertedProps);

this.sqsQueue = wrappedConstruct.sqsQueue;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ export class EventsRuleToStepFunction extends Construct {
constructor(scope: Construct, id: string, props: EventsRuleToStepFunctionProps) {
super(scope, id);
const convertedProps: EventsRuleToStepFunctionProps = { ...props };

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new EventbridgeToStepfunctions instead of EventsRuleToStepFunction)
const wrappedConstruct: EventsRuleToStepFunction = new EventbridgeToStepfunctions(this, `${id}W`, convertedProps);

this.stateMachine = wrappedConstruct.stateMachine;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ export class LambdaToStepFunction extends Construct {
constructor(scope: Construct, id: string, props: LambdaToStepFunctionProps) {
super(scope, id);
const convertedProps: LambdaToStepFunctionProps = { ...props };

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new LambdaToStepfunctions instead of LambdaToStepFunction)
const wrappedConstruct: LambdaToStepFunction = new LambdaToStepfunctions(this, `${id}W`, convertedProps);

this.lambdaFunction = wrappedConstruct.lambdaFunction;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ export class S3ToStepFunction extends Construct {
constructor(scope: Construct, id: string, props: S3ToStepFunctionProps) {
super(scope, id);
const convertedProps: S3ToStepFunctionProps = { ...props };

// W (for 'wrapped') is added to the id so that the id's of the constructs with the old and new names don't collide
// If this character pushes you beyond the 64 character limit, just import the new named construct and instantiate
// it in place of the older named version. They are functionally identical, aside from the types no other changes
// will be required. (eg - new S3ToStepfunctions instead of S3ToStepFunction)
const wrappedConstruct: S3ToStepFunction = new S3ToStepfunctions(this, `${id}W`, convertedProps);

this.stateMachine = wrappedConstruct.stateMachine;
Expand Down

0 comments on commit 773406c

Please sign in to comment.