Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer IDs in deprecated constructs breaking existing installations #369

Closed
biffgaut opened this issue Sep 13, 2021 · 2 comments · Fixed by #371
Closed

Longer IDs in deprecated constructs breaking existing installations #369

biffgaut opened this issue Sep 13, 2021 · 2 comments · Fixed by #371
Assignees
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged

Comments

@biffgaut
Copy link
Contributor

biffgaut commented Sep 13, 2021

PR 315 increased the length of the id by seven characters ("-wrapped") when it launches implementation of the construct with a new name inside the shel with the old name.

Unfortunately both the shell and the internal construct can't use the same name, so we must alter the id in some way if we don't alter the actual id sent from the client. We will:

  • Change the added text to just "w" to reduce the number of implementations impacted
  • The fix for implementations that are still impacted is to switch to the new constructs. As they are functionally equivalent, this is very simple - merely npm install'ing the new construct and changing the type references in the code.

There are about 8 renamed constructs where this pattern needs to be addressed.

Reproduction Steps

See comment in PR 315

Error Log

Environment

  • CDK CLI Version :
  • CDK Framework Version:
  • AWS Solutions Constructs Version :
  • OS :
  • Language :

Other


This is 🐛 Bug Report

@pvbouwel
Copy link
Contributor

Shortening the wrapping would have worked in my case. Since it is often a good time to switch away from deprecated constructs I've switched (in my case aws-events-rule-sqs -> aws-eventbridge-sqs) to the new constructs and that works also great as expected . Thanks

@biffgaut
Copy link
Contributor Author

Glad to hear the transition to the new name went smoothly - we tried to ensure this but it still gives us some concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged
Projects
None yet
3 participants