Add Test Cases for Metric Rollup Addition of [RemoteService, RemoteTarget, ...] #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
debb2a2 to
c1019cf
Compare
c1019cf to
12f4634
Compare
validator/src/main/java/com/amazon/aoc/validators/CWMetricValidator.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/validators/CWMetricValidator.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/validators/CWMetricValidator.java
Outdated
Show resolved
Hide resolved
validator/src/main/resources/expected-data-template/eks/aws-sdk-call-metric.mustache
Outdated
Show resolved
Hide resolved
validator/src/test/java/com/amazon/aoc/validators/CWMetricValidatorTest.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/validators/CWMetricValidator.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/validators/CWMetricValidator.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/amazon/aoc/validators/CWMetricValidator.java
Outdated
Show resolved
Hide resolved
majanjua-amzn
approved these changes
May 7, 2024
This was referenced May 7, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Add Test Cases for Metric Rollup Addition of [RemoteService, RemoteTarget, ...]
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Add Test Cases for Metric Rollup Addition of [RemoteService, RemoteTarget, ...]
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Add Test Cases for Metric Rollup Addition of [RemoteService, RemoteTarget, ...]
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
Add Test Cases for Metric Rollup Addition of [RemoteService, RemoteTarget, ...]
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
In this commmit we are removing support for Python 3.7, to align with upstream: open-telemetry/opentelemetry-python-contrib#2152 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/amazon-cloudwatch-agent#1010
Recently the following metric rollups were added to 2 AppSignal Configuration files. Tests need to be added for them
[RemoteService, RemoteTarget][HostedIn.<Attributes>, Service, RemoteService, RemoteTarget]Description of changes:
Add tests for new metric rollups
testingId=${{ env.TESTING_ID }}to the sample app via request-body to generate new metrics and pass new Metric Validations--remote-target-name ::s3:::e2e-test-bucket-name-${{ env.TESTING_ID }}to validator so it can query new metricsRemoteTargetvalue that includes testingId::s3:::e2e-test-bucket-name-{{testingId}})RemoteTarget=<s3_bucket_name_input>Testing done:
15 minute canaries running successfully for 12+ hours:
EC2 Java in IAD: https://github.com/jj22ee/aws-application-signals-test-framework/actions/workflows/test-ec2-java.yml
EKS Java in IAD: https://github.com/jj22ee/aws-application-signals-test-framework/actions/workflows/test-eks-java.yml
EC2 Python in IAD: https://github.com/jj22ee/aws-application-signals-test-framework/actions/workflows/test-ec2-python.yml
EKS Python in IAD: https://github.com/jj22ee/aws-application-signals-test-framework/actions/workflows/test-eks-python.yml
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.