Fix - Rename parameter name in e2e metric limiter test workflow #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majanjua-amzn
approved these changes
May 7, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…rename Fix - Rename parameter name in e2e metric limiter test workflow
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…rename Fix - Rename parameter name in e2e metric limiter test workflow
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…rename Fix - Rename parameter name in e2e metric limiter test workflow
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…rename Fix - Rename parameter name in e2e metric limiter test workflow
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
In this commit we are making a few small changes to contract tests and pr_build: * In image Dockerfile upgrade pip and use PIP_ROOT_USER_ACTION=ignore to avoid unneeded warnings in image build process * In contract test base, make use of `addCleanup`, which (based on TestCase documentation) will always run, even if `setUp` fails, (unlike tearDown). This ensures tests reliably clean up and avoids issues with failures in setup. * In PR build, break out lint/spellcheck into their own jobs to keep workflow clean and lean. Add the ability to optionally run unit tests to setup steps, for saving some runtime of lint/spellcheck. * In PR build, disable fail-fast. If one matrix invocation fails, we still want to see the others to catch multiple issues if they are present. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
bjrara
added a commit
that referenced
this pull request
Jul 23, 2024
*Issue description:* Use released helm version to avoid canary failure. Commit picked from aws-observability/helm-charts#57. Verified ``` amazon-cloudwatch-observability % pwd /Users/zmengyi/go/src/github.com/aws-observability/helm-charts/charts/amazon-cloudwatch-observability amazon-cloudwatch-observability % git reset --hard e0e99c77f69ef388b0ffce769371f7c735a776e4 HEAD is now at e0e99c7 release 1.8.0 (#57) ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8990123840/job/24694768687
Description of changes:
Missed var name change that is required after #41
request-body->query-stringBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.