Update E2E Tests Expected Data for K8s #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
There should be changes in aws-sdk-call-log.mustache and aws-sdk-call-trace.mustache as well. Those files use RegEx so the difference in value wasn't detected because the RegEx ::s3:::e2e-test-bucket-name still detects ::s3:::e2e-test-bucket-name-{{testingId}}
You should replace that RegEx with ^::s3:::e2e-test-bucket-name-{{testingId}}$ which enforces the start and end of the string.
For trace and logs tests, the workflows do not send the Testing ID to the Sample App. So for these logs/traces tests, the S3 bucket name will still be |
majanjua-amzn
approved these changes
May 13, 2024
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…lup-test-update Update E2E Tests Expected Data for K8s
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…lup-test-update Update E2E Tests Expected Data for K8s
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…lup-test-update Update E2E Tests Expected Data for K8s
zzhlogin
pushed a commit
to zzhlogin/aws-application-signals-test-framework
that referenced
this pull request
Jun 6, 2024
…lup-test-update Update E2E Tests Expected Data for K8s
georgeboc
pushed a commit
to georgeboc/aws-application-signals-test-framework
that referenced
this pull request
Jul 8, 2024
In this commit, we are adding patches for upstream botocore instrumentation. The rationale for patching is as follows: 1. We need a few botocore-related span attributes (resource names for RemoteTarget), for feature parity with Java instrumentation. 2. Getting these changes to the upstream is likely to take too long for our release timeline. As such, we have decided that local monkey patches help us meet our goals. Note that the risks of monkey patching (namely that the underlying library changes underneath us) are mitigated by a) comprehensive unit tests and b) (upcoming) contract tests. Key diff (from testing done): ``` BEFORE: "aws.dynamodb.table_names": [ "testtable"], "aws.queue_url": "testqueue", AFTER: "aws.dynamodb.table_names": ["testtable"], "aws.kinesis.stream_name": "teststrean", "aws.s3.bucket": "testbucket", "aws.sqs.queue_name": "testqueue", "aws.queue_url": "testqueue", "aws.sqs.queue_url": "testqueue", ``` By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Followup from: #41
Previously, new metric rollup test cases were added for EC2 and EKS e2e tests in Python and Java. These need to be added for K8s e2e tests as well.
Description of changes:
Updating k8s tests (workflow and expected data) to have the same changes previously applied for EC2/EKS.
Additionally, changes were made to make the generated data between logs/metrics/traces to be more consistent in the tests.
Testing:
Ran K8s tests a few times In IAD using a node for testing changes: https://github.com/aws-observability/aws-application-signals-test-framework/actions/workflows/test.yml
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.