Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_map_msgs): add selected map loading #57

Merged

Conversation

Shin-kyoto
Copy link
Contributor

@Shin-kyoto Shin-kyoto commented Apr 7, 2023

Description

Add autoware_map_msgs to integrate a new interface for selected map loading.
See https://github.com/orgs/autowarefoundation/discussions/2812#discussioncomment-5540316 for detail.

Related links

The next step of this PR would be to create a selected map loading functionality in map_loader. Here's how it's going to look like: autowarefoundation/autoware.universe#3286

Tests performed

Notes for reviewers

  • Are there any better names for each messages/service?

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
@Shin-kyoto Shin-kyoto requested review from yukkysaito and kminoda April 7, 2023 12:49
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
autoware_map_msgs/msg/PointCloudMapMetaData.msg Outdated Show resolved Hide resolved
autoware_map_msgs/README.md Outdated Show resolved Hide resolved
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
…rehand

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
…ry for service

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants