-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_map_msgs): add selected map loading #57
Merged
Shin-kyoto
merged 8 commits into
autowarefoundation:main
from
Shin-kyoto:feat/add_selected_map_loading
Apr 11, 2023
Merged
feat(autoware_map_msgs): add selected map loading #57
Shin-kyoto
merged 8 commits into
autowarefoundation:main
from
Shin-kyoto:feat/add_selected_map_loading
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
This was referenced Apr 7, 2023
kminoda
reviewed
Apr 9, 2023
Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
…rehand Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
…ry for service Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
7 tasks
kminoda
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yukkysaito
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add autoware_map_msgs to integrate a new interface for selected map loading.
See https://github.com/orgs/autowarefoundation/discussions/2812#discussioncomment-5540316 for detail.
Related links
The next step of this PR would be to create a selected map loading functionality in map_loader. Here's how it's going to look like: autowarefoundation/autoware.universe#3286
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.