Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_loader): add param for selected_map_loader #285

Merged

Conversation

Shin-kyoto
Copy link
Contributor

@Shin-kyoto Shin-kyoto commented Apr 7, 2023

Description

Please see autowarefoundation/autoware.universe#3286 for details
This PR changes config for PR above in autoware.universe.

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
takayuki5168 referenced this pull request in tier4/autoware_launch Apr 7, 2023
Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
@Shin-kyoto Shin-kyoto self-assigned this Apr 10, 2023
@Shin-kyoto Shin-kyoto changed the title feat(map_loader): add param for selected_nap_loader feat(map_loader): add param for selected_map_loader Apr 10, 2023
@Shin-kyoto Shin-kyoto marked this pull request as ready for review April 10, 2023 07:09
@Shin-kyoto Shin-kyoto requested a review from kminoda April 10, 2023 07:09
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shin-kyoto Shin-kyoto merged commit 32c4dad into autowarefoundation:main Apr 11, 2023
takayuki5168 referenced this pull request in tier4/autoware_launch May 21, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants