Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(duplicated_node_checker): print duplication name #888

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 26, 2024

Description

print which node name is duplicate

Tests performed

[system_error_monitor-17] [ERROR 1708923402.776953195] [system_error_monitor /autoware/system/duplicated_node_checker/duplicated_node_checker: duplicated_node_checker]: [Single Point Fault]: Error: Duplicated nodes detected[/dummy_diagnostics],

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin closed this Mar 13, 2024
@soblin soblin deleted the chore/print-duplicate-node-name branch March 13, 2024 03:06
@soblin soblin restored the chore/print-duplicate-node-name branch March 13, 2024 09:45
@soblin soblin reopened this Mar 13, 2024
@soblin soblin merged commit 92c8c10 into autowarefoundation:main Mar 13, 2024
16 of 18 checks passed
@soblin soblin deleted the chore/print-duplicate-node-name branch March 13, 2024 09:50
4swinv pushed a commit to 4swinv/autoware_launch that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants