Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(duplicate_node_checker): print duplication name #6488

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 26, 2024

Description

autowarefoundation/autoware_launch#888

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin requested a review from shmpwk as a code owner February 26, 2024 04:58
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Feb 26, 2024
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 26, 2024
@soblin soblin enabled auto-merge (squash) February 26, 2024 04:59
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk
Copy link
Contributor

shmpwk commented Feb 26, 2024

cc. @Owen-Liuyuxuan

@Owen-Liuyuxuan
Copy link
Contributor

Thank you, LGTM!

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 14.64%. Comparing base (b86a00d) to head (770b90b).
Report is 1 commits behind head on main.

Files Patch % Lines
..._node_checker/src/duplicated_node_checker_core.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6488   +/-   ##
=======================================
  Coverage   14.64%   14.64%           
=======================================
  Files        1899     1899           
  Lines      130282   130282           
  Branches    38311    38311           
=======================================
  Hits        19083    19083           
  Misses      89784    89784           
  Partials    21415    21415           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.64% <ø> (+<0.01%) ⬆️ Carriedforward from b86a00d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 209b672 into autowarefoundation:main Feb 26, 2024
30 of 33 checks passed
@soblin soblin deleted the chore/print-duplicate-node-name branch February 26, 2024 12:50
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Mar 4, 2024
saka1-s added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
…tion#6488) (#1180)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Co-authored-by: Mamoru Sobue <hilo.soblin@gmail.com>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants