Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): add min_assumed_velocity parameter #548

Conversation

maxime-clem
Copy link
Contributor

Description

Add parameter required for the universe PR autowarefoundation/autoware.universe#4784

Tests performed

Psim and evaluator.

Effects on system behavior

Less incorrect stops when using the out_of_lane module, and when ego is stopped or driving slowly, stops are triggered more consistently.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-add_min_assumed_velocity branch from df0ba5b to fce467d Compare September 1, 2023 05:15
@maxime-clem maxime-clem merged commit d5b427a into autowarefoundation:main Sep 1, 2023
@maxime-clem maxime-clem deleted the feat/out_of_lane-add_min_assumed_velocity branch September 1, 2023 06:38
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
Signed-off-by: kminoda <koji.m.minoda@gmail.com>

Signed-off-by: kminoda <koji.m.minoda@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
chore: sync awf/autoware_launch
maxime-clem added a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
…tion#548)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to maxime-clem/autoware_launch that referenced this pull request Sep 25, 2023
…tion#548)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…ion#548)

* fix(perception): add detection_by_tracker param file (autowarefoundation#676)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: disable DBT for car

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
yuki-takagi-66 referenced this pull request in tier4/autoware_launch Jul 8, 2024
* fix(perception): add detection_by_tracker param file (#676)

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

* fix: disable DBT for car

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>

---------

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants