Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repos): add gnss/imu localizer #3261

Merged
merged 6 commits into from
Apr 26, 2023
Merged

feat(repos): add gnss/imu localizer #3261

merged 6 commits into from
Apr 26, 2023

Conversation

rsasaki0109
Copy link
Contributor

@rsasaki0109 rsasaki0109 commented Feb 8, 2023 •
edited
Loading

Description

This is the PR for integrating GNSS/IMU localizar discussed in the discussion below.
#3257
Add GNSS/IMU localizar related packages to autoware.repos

Related links

autowarefoundation/autoware_launch#200
autowarefoundation/autoware.universe#3063
autowarefoundation/autoware-documentation#334

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

This was referenced Feb 9, 2023
Closed
Merged
@rsasaki0109 rsasaki0109 changed the title Feat/add gnss imu localizar feat:add gnss imu localizar Feb 9, 2023
@rsasaki0109 rsasaki0109 changed the title feat:add gnss imu localizar feat(repos): add gnss/imu localizar Feb 9, 2023
@rsasaki0109 rsasaki0109 added component:localization Vehicle's position determination in its environment. and removed component:localization Vehicle's position determination in its environment. labels Feb 9, 2023
@rsasaki0109 rsasaki0109 mentioned this pull request Feb 9, 2023
Merged
@rsasaki0109
Copy link
Contributor Author

spell-check-differential.ci run

@rsasaki0109 rsasaki0109 marked this pull request as ready for review February 9, 2023 09:22
yukkysaito
yukkysaito reviewed Feb 9, 2023
View reviewed changes
autoware.repos Outdated Show resolved Hide resolved
@yukkysaito
Copy link
Contributor

yukkysaito commented Feb 9, 2023 •
edited
Loading

@rsasaki0109 Will there be a lot of changes in the branches of the repository that you have added?
If you are unsure, it might be better to have it tagged or commit hash, as changes to eagleye could make it impossible to build.

@rsasaki0109
Copy link
Contributor Author

rsasaki0109 commented Feb 9, 2023 •
edited
Loading

@yukkysaito
We usually develop eagleye in the develop-rosX branch and fixed the version of eagleye in autoware.repos to autoware-main branch.

Screenshot from 2023-02-09 18-53-00

@xmfcx xmfcx changed the title feat(repos): add gnss/imu localizar feat(repos): add gnss/imu localizer Feb 9, 2023
rsasaki0109 and others added 6 commits February 9, 2023 19:52
@rsasaki0109
Add gnss_imu_localizar
eb3112a 
Signed-off-by: Ryohei Sasaki <ryohei.sasaki@map4.jp>
@rsasaki0109
Delete duplicate description
d530e3d 
Signed-off-by: Ryohei Sasaki <ryohei.sasaki@map4.jp>
@rsasaki0109
Update eagleye version in autoware.repos
3176e65 
Signed-off-by: Ryohei Sasaki <ryohei.sasaki@map4.jp>
@rsasaki0109
Add llh_converter in autoware.repos
bea3995 
Signed-off-by: Ryohei Sasaki <ryohei.sasaki@map4.jp>
@rsasaki0109
Update autoware.repos
95141dd 
Signed-off-by: Ryohei Sasaki <ryohei.sasaki@map4.jp>
@rsasaki0109 @yukkysaito
Update eagleye url in autoware.repos
3236467 
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: Ryohei Sasaki <ryohei.sasaki@map4.jp>
@mitsudome-r mitsudome-r mentioned this pull request Feb 20, 2023
Open
3 tasks
@rsasaki0109 rsasaki0109 mentioned this pull request Feb 21, 2023
Merged
@rsasaki0109 rsasaki0109 mentioned this pull request Mar 13, 2023
Merged
4 tasks
kminoda
kminoda approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsasaki0109
Copy link
Contributor Author

rsasaki0109 commented Apr 24, 2023 •
edited
Loading

@yukkysaito @mitsudome-r (@YamatoAndo )
Please also check the PR regarding Eagleye here.

Yabuuchi-san(@KYabuuchi) has already verified the operation of this PR on the TIER IV side.
autowarefoundation/autoware.universe#3063 (review)

@kminoda
Copy link
Contributor

kminoda commented Apr 26, 2023

@rsasaki0109 What is the status of this PR? (Probably we need a help of someone who has write privilege such as @mitsudome-r ?)

@rsasaki0109
Copy link
Contributor Author

rsasaki0109 commented Apr 26, 2023 •
edited
Loading

@kminoda
This PR requires one more approval review from a reviewer with write access. After approval, as @kminoda san mentioned, I will need help from someone with write permission to proceed with the merge.

@yukkysaito (@mitsudome-r )
I assumed it was you who would do the review, but do you think it would be better to ask @kenji-miyake san or @xmfcx san for it?

@rsasaki0109
Copy link
Contributor Author

rsasaki0109 commented Apr 26, 2023 •
edited
Loading

@mitsudome-r @yukkysaito （perhaps @mitsudome-r san?）
My apologies. I was mistaken. It looks like this PR is already ready to be merged, but I don't have the authority to merge it. Could you please merge this?

@yukkysaito
Copy link
Contributor

👍

@yukkysaito yukkysaito merged commit eb0ac2a into autowarefoundation:main Apr 26, 2023
@rsasaki0109
Copy link
Contributor Author

rsasaki0109 commented Apr 26, 2023 •
edited
Loading

@kminoda @KYabuuchi @yukkysaito
Since the PR for the autoware repositories have been merged, could you please merge the following autoware_launch and autoware.universe PRs?
I don't have merge authority.

autowarefoundation/autoware.universe#3063
autowarefoundation/autoware_launch#200

@rsasaki0109 rsasaki0109 deleted the feat/add_gnss_imu_localizar branch April 26, 2023 07:54
@kminoda
Copy link
Contributor

kminoda commented Apr 26, 2023

@rsasaki0109 Done!

@kminoda kminoda mentioned this pull request Apr 26, 2023
Closed
3 tasks
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Apr 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito left review comments

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@kminoda kminoda kminoda approved these changes

@xmfcx xmfcx Awaiting requested review from xmfcx xmfcx is a code owner

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Localization & Mapping Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsasaki0109 @yukkysaito @kminoda @mitsudome-r