-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gnss/imu localizer #2848
feat: add gnss/imu localizer #2848
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2848 +/- ##
==========================================
- Coverage 11.93% 11.67% -0.27%
==========================================
Files 1326 1321 -5
Lines 92209 90949 -1260
Branches 24649 24013 -636
==========================================
- Hits 11008 10621 -387
+ Misses 69788 69181 -607
+ Partials 11413 11147 -266
*This pull request uses carry forward flags. Click here to find out more. see 295 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
launch/tier4_localization_launch/launch/localization.launch.xml
Outdated
Show resolved
Hide resolved
...ier4_localization_launch/launch/pose_twist_fusion_filter/pose_twist_fusion_filter.launch.xml
Outdated
Show resolved
Hide resolved
...ier4_localization_launch/launch/pose_twist_fusion_filter/pose_twist_fusion_filter.launch.xml
Outdated
Show resolved
Hide resolved
@yukkysaito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! First, I have some comments on the parameters that are introduced in this PR.
launch/tier4_localization_launch/launch/localization.launch.xml
Outdated
Show resolved
Hide resolved
launch/tier4_localization_launch/launch/localization.launch.xml
Outdated
Show resolved
Hide resolved
launch/tier4_localization_launch/launch/localization.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: GitHub <noreply@github.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
The commits went wrong, should I close this PR and submit a different one...? status |
@rsasaki0109 I don't know the exact rules, but this PR with similar mistakes has been closed and re-created. |
Description
This is the PR for integrating GNSS/IMU localizar discussed in the discussion below.
https://github.com/orgs/autowarefoundation/discussions/3257
localization_mode
pose_estimator_mode
(lidar, gnss),eaglye_twist
twist_estimator_mode
(gyro_odom_fusion, gyro_odom_gnss_fusion) parameter inlocalization.launch.xml
to switch between pose,twistlaunch/tier4_localization_launch/launch/eagleye/fix2pose.xml
.Related links
autowarefoundation/autoware#3261
autowarefoundation/autoware_launch#200
autowarefoundation/autoware-documentation#334
Tests performed
Localizaiton methods are expected to work as normal, even if they change.
Sample rosbag is available for simple operation tests.
Also, if you have a rosbag of a system with the same configuration of sensors, you can check the operation to some extent.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.