Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtc_interface): update cooperateStatus state transition #8883

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

go-sakayori
Copy link
Contributor

@go-sakayori go-sakayori commented Sep 17, 2024

Description

In the previous PR, the below state transition was not allowed.

  • FAILED -> FAILED
  • SUCCESS -> SUCCESS

This PR allows the above state transition.

Related links

#8855

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 17, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@go-sakayori go-sakayori added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.92%. Comparing base (6effe2c) to head (dc68acd).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...nning/autoware_rtc_interface/src/rtc_interface.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8883      +/-   ##
==========================================
- Coverage   27.92%   27.92%   -0.01%     
==========================================
  Files        1324     1328       +4     
  Lines       98877    98907      +30     
  Branches    39821    39823       +2     
==========================================
  Hits        27615    27615              
- Misses      71210    71240      +30     
  Partials       52       52              
Flag Coverage Δ *Carryforward flag
differential 24.13% <0.00%> (?)
total 27.92% <ø> (ø) Carriedforward from 6effe2c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@go-sakayori go-sakayori merged commit 8ea618a into autowarefoundation:main Sep 17, 2024
43 of 44 checks passed
@go-sakayori go-sakayori deleted the fix/rtc_state_transition branch September 17, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants