Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(static_obstacle_avoidance): update UUID when candidate shift is empty #8901

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

go-sakayori
Copy link
Contributor

@go-sakayori go-sakayori commented Sep 18, 2024

Description

Fix rtc state transition error for static_obstacle_avoidance module.
There was a problem that the same UUID was used for candidates shift line, although the cooperateStatus has been changed to FAILED.

[WARN] [1726619093.498740895] [planning.scenario_planning.lane_driving.behavior_planning.behavior_path_planner.RTCInterface[static_obstacle_avoidance_left]]: [updateCooperateStatus] uuid : 8c50d0b80d2539be7fc496c00e153d7a cannot transit from FAILED to WAITING_FOR_EXECUTION

This happens when removeCandidateRTCStatus function is once called, and the candidate is re-registered in the next period.
This PR generates a new UUID once the removeCandidateRTCStatus function is called.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Go Sakayori <go.sakayori@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 18, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@go-sakayori go-sakayori added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.00%. Comparing base (28a389b) to head (25e6b1f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...or_path_static_obstacle_avoidance_module/scene.hpp 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8901      +/-   ##
==========================================
- Coverage   28.00%   28.00%   -0.01%     
==========================================
  Files        1319     1320       +1     
  Lines       98699    98720      +21     
  Branches    39787    39791       +4     
==========================================
+ Hits        27641    27645       +4     
- Misses      70989    71006      +17     
  Partials       69       69              
Flag Coverage Δ *Carryforward flag
differential 20.99% <25.00%> (?)
total 28.00% <ø> (ø) Carriedforward from 28a389b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@go-sakayori go-sakayori merged commit 2c475ba into autowarefoundation:main Sep 18, 2024
46 checks passed
@go-sakayori go-sakayori deleted the fix/soa_candidate_rtc branch September 18, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants