Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix rtc state update logic #8899

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

go-sakayori
Copy link
Contributor

@go-sakayori go-sakayori commented Sep 17, 2024

Description

Fix rtc state transition error for behavior_path_planner modules.
Specifically, the following warning would be fixed.

[component_container_mt-33] [WARN] [1726603502.777678240] [planning.scenario_planning.lane_driving.behavior_planning.behavior_path_planner.RTCInterface[goal_planner]]: [updateCooperateStatus]  Cannot register RUNNING as initial state

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 17, 2024
Copy link

github-actions bot commented Sep 17, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Go Sakayori <gsakayori@gmail.com>
@go-sakayori go-sakayori marked this pull request as ready for review September 18, 2024 00:51
@go-sakayori go-sakayori added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 18, 2024
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@go-sakayori go-sakayori enabled auto-merge (squash) September 18, 2024 01:31
@go-sakayori go-sakayori merged commit cd82008 into autowarefoundation:main Sep 18, 2024
40 checks passed
@go-sakayori go-sakayori deleted the fix/bpp_rtc_state branch September 18, 2024 01:44
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.99%. Comparing base (28a389b) to head (ecf10b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lanner_common/interface/scene_module_interface.hpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8899      +/-   ##
==========================================
- Coverage   28.00%   27.99%   -0.02%     
==========================================
  Files        1319     1325       +6     
  Lines       98699    98745      +46     
  Branches    39787    39788       +1     
==========================================
  Hits        27641    27641              
- Misses      70989    71035      +46     
  Partials       69       69              
Flag Coverage Δ *Carryforward flag
differential 16.23% <0.00%> (?)
total 28.00% <ø> (ø) Carriedforward from 28a389b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants