Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autonomous_emergency_braking): fix debug marker visual bug #8611

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix(autonomous_emergency_braking): fix debug marker visual bug #8611

merged 1 commit into from
Aug 26, 2024

Conversation

danielsanchezaran
Copy link
Contributor

Description

In current OSS Autoware there is a visual bug that makes it so the rss distance is always 0. This is caused because the RSS distance is calculated AFTER the debug marker is published, this PR fixes the problem by calculating the distance first (which is saved on the collision_data_keeper_ member class) and then, using that data to publish the debug info.

Related links

Parent Issue:

  • Link

How was this PR tested?

PSim
cap- 2024-08-26-14-06-38

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@danielsanchezaran
fix bug by using the collision data keeper
6b5b72c 
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran marked this pull request as ready for review August 26, 2024 05:15
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Aug 26, 2024
@danielsanchezaran danielsanchezaran added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Aug 26, 2024
@github-actions GitHub Actions
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@danielsanchezaran danielsanchezaran enabled auto-merge (squash) August 26, 2024 05:20
@danielsanchezaran danielsanchezaran merged commit b35ad4b into autowarefoundation:main Aug 26, 2024
37 checks passed
@danielsanchezaran danielsanchezaran deleted the fix/aeb_rss_debug_marker_as_0 branch August 26, 2024 05:26
@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 24.09%. Comparing base (c9bb1e1) to head (6b5b72c).
Report is 3 commits behind head on main.

Files Patch % Lines
...autoware_autonomous_emergency_braking/src/node.cpp 0.00% 9 Missing ⚠️
...ude/autoware/autonomous_emergency_braking/node.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8611      +/-   ##
==========================================
- Coverage   24.10%   24.09%   -0.01%     
==========================================
  Files        1399     1401       +2     
  Lines      102455   102484      +29     
  Branches    38912    38915       +3     
==========================================
+ Hits        24694    24696       +2     
- Misses      75223    75250      +27     
  Partials     2538     2538
Flag Coverage Δ *Carryforward flag
differential 5.79% <0.00%> (?)
total 24.10% <ø> (+<0.01%) ⬆️ Carriedforward from c9bb1e1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
@danielsanchezaran @kyoichi-sugahara
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
c398ce5 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Sep 2, 2024
@danielsanchezaran
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
c768ac1 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
@danielsanchezaran @a-maumau
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
020c53d 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Sep 10, 2024
@danielsanchezaran
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
93c4240 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Sep 11, 2024
@danielsanchezaran
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
10c1582 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
@danielsanchezaran @ktro2828
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
ca7f390 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 20, 2024
@danielsanchezaran @kosuke55
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
ccd4141 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 20, 2024
@danielsanchezaran @kosuke55
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
4df7855 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Sep 27, 2024
@danielsanchezaran
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
337124c 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 1, 2024
@danielsanchezaran @pre-commit-ci
feat(autonomous_emergency_braking): aeb update for v0.3.19 (#1558)
c6d7459 
* add AEB updated module

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* change back msgs and other things

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix name of aeb in sys error monitor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* delete old AEB package

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(autonomous_emergency_braking): enable aeb with only one req path (autowarefoundation#8569)

* make it so AEB works with only one req path type (imu or MPC)

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix missing mpc path return

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add check

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* modify no path msg

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix(autonomous_emergency_braking): fix debug marker visual bug (autowarefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* docs(autonomous_emergency_braking): add missing params to README (autowarefoundation#8950)

add missing params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2024
@danielsanchezaran
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
ca47de3 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2024
@danielsanchezaran
fix(autonomous_emergency_braking): fix debug marker visual bug (autow…
07ffb45 
…arefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soblin soblin soblin approved these changes

@kyoichi-sugahara kyoichi-sugahara kyoichi-sugahara approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees

@kyoichi-sugahara kyoichi-sugahara

Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielsanchezaran @soblin @kyoichi-sugahara