Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(autonomous_emergency_braking): add missing params to README #8950

Conversation

danielsanchezaran
Copy link
Contributor

Description

This PR edits the README to include some missing parameters

Related links

Parent Issue:

  • Link

How was this PR tested?

N/A

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
@danielsanchezaran danielsanchezaran changed the title docs(autonomous_emergency_braking): add missing params docs(autonomous_emergency_braking): add missing params to README Sep 25, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) labels Sep 25, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@danielsanchezaran danielsanchezaran added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 25, 2024
@danielsanchezaran danielsanchezaran marked this pull request as ready for review September 25, 2024 02:10
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.02%. Comparing base (9f7ba86) to head (ede0261).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8950      +/-   ##
==========================================
- Coverage   28.02%   28.02%   -0.01%     
==========================================
  Files        1316     1317       +1     
  Lines       98601    98628      +27     
  Branches    39771    39774       +3     
==========================================
+ Hits        27636    27639       +3     
- Misses      70819    70843      +24     
  Partials      146      146              
Flag Coverage Δ *Carryforward flag
differential 7.24% <ø> (?)
total 28.02% <ø> (ø) Carriedforward from 9f7ba86

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielsanchezaran danielsanchezaran merged commit 73a9788 into autowarefoundation:main Sep 25, 2024
44 checks passed
@danielsanchezaran danielsanchezaran deleted the docs/fix-aeb-missing-readme-params branch September 25, 2024 02:24
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Sep 25, 2024
…owarefoundation#8950)

add missing params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Sep 27, 2024
…owarefoundation#8950)

add missing params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 1, 2024
* add AEB updated module

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* change back msgs and other things

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix name of aeb in sys error monitor

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* delete old AEB package

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* feat(autonomous_emergency_braking): enable aeb with only one req path (autowarefoundation#8569)

* make it so AEB works with only one req path type (imu or MPC)

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix missing mpc path return

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* add check

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* modify no path msg

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* fix(autonomous_emergency_braking): fix debug marker visual bug (autowarefoundation#8611)

fix bug by using the collision data keeper

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* docs(autonomous_emergency_braking): add missing params to README (autowarefoundation#8950)

add missing params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* ci(pre-commit): autofix

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…owarefoundation#8950)

add missing params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Oct 28, 2024
…owarefoundation#8950)

add missing params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
danielsanchezaran added a commit to tier4/autoware.universe that referenced this pull request Nov 14, 2024
…owarefoundation#8950)

add missing params

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants