Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated pre-commit-hooks-ros version from v0.8.0 to v0.9.0 #8527

Merged

Conversation

kosuke55
Copy link
Contributor

Description

use same version to autowarefoundation/autoware_launch#971

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Aug 19, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 requested a review from HansRobo August 19, 2024 08:29
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Aug 19, 2024
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.89%. Comparing base (a6b0df9) to head (d54942e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8527      +/-   ##
==========================================
- Coverage   23.90%   23.89%   -0.01%     
==========================================
  Files        1381     1382       +1     
  Lines      101924   101923       -1     
  Branches    38818    38810       -8     
==========================================
- Hits        24364    24355       -9     
- Misses      75076    75084       +8     
  Partials     2484     2484              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 23.90% <ø> (-0.01%) ⬇️ Carriedforward from 2f392a8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55
Copy link
Contributor Author

merge #8529 first

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/update-pre-commit-hooks-ros branch from d54942e to c1c54fa Compare August 20, 2024 01:20
@github-actions github-actions bot removed the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Aug 20, 2024
@kosuke55 kosuke55 enabled auto-merge (squash) August 20, 2024 01:21
@kosuke55 kosuke55 merged commit daa04dc into autowarefoundation:main Aug 20, 2024
24 checks passed
@kosuke55 kosuke55 deleted the fix/update-pre-commit-hooks-ros branch August 20, 2024 01:50
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants