Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autowre_accel_brake_map_calibrator): fix for flake-ros v0.9.0 #8529

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 19, 2024

Description

fix for #8527

image

https://results.pre-commit.ci/run/github/429651616/1724056061.MLB04FzrTtu8RBn8sIvggg

Related links

Parent Issue:

  • Link

How was this PR tested?

pre-commit run

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Aug 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 19, 2024
@kosuke55
Copy link
Contributor Author

@tkimura4 @taikitanaka3
could you please check this PR? 🙇

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.89%. Comparing base (a6b0df9) to head (29da6a7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8529      +/-   ##
==========================================
- Coverage   23.90%   23.89%   -0.01%     
==========================================
  Files        1381     1382       +1     
  Lines      101924   101923       -1     
  Branches    38818    38810       -8     
==========================================
- Hits        24364    24355       -9     
- Misses      75076    75084       +8     
  Partials     2484     2484              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 23.90% <ø> (-0.01%) ⬇️ Carriedforward from 2f392a8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 enabled auto-merge (squash) August 19, 2024 10:23
@kosuke55 kosuke55 merged commit 56ba7f9 into autowarefoundation:main Aug 19, 2024
43 checks passed
@kosuke55 kosuke55 deleted the refactor/accel_brake_map_calib_flake branch August 19, 2024 15:10
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants