Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(radar_scan_to_pointcloud2, radar_static_pointcloud_filter, radar_threshold_filter)!: add package name prefix of autoware_ #8132

Conversation

technolojin
Copy link
Contributor

Description

This PR adds the autoware_ prefix to the package name.

  • radar_scan_to_pointcloud2
  • radar_static_pointcloud_filter
  • radar_threshold_filter

Changes are as following.

  1. Folder name (appears as file renaming)
  2. Package names in CMakeLists.txt, package.xml
  3. README.md
  4. Launch files $(find-pkg-share ...)
  5. .github/CODEOWNERS

This PR do not contains any logic change.

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested locally launched by its own README guide.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@technolojin technolojin marked this pull request as ready for review July 22, 2024 09:35
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jul 22, 2024
Copy link

github-actions bot commented Jul 22, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.15%. Comparing base (04f7c6c) to head (0d139be).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #8132    +/-   ##
========================================
  Coverage   29.14%   29.15%            
========================================
  Files        1609     1614     +5     
  Lines      118111   118300   +189     
  Branches    50839    50903    +64     
========================================
+ Hits        34423    34489    +66     
- Misses      74441    74615   +174     
+ Partials     9247     9196    -51     
Flag Coverage Δ *Carryforward flag
differential 3.50% <ø> (?)
total 29.14% <ø> (-0.01%) ⬇️ Carriedforward from 04f7c6c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…nces

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

fix: rename package folder

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…eferences

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: update launch file name for autoware_radar_static_pointcloud_filter
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/prefix-packagename-radar-gr2 branch from 4ab1e20 to 0d139be Compare July 22, 2024 09:51
@technolojin technolojin enabled auto-merge (squash) July 22, 2024 10:00
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit fe03b39 into autowarefoundation:main Jul 23, 2024
29 of 30 checks passed
@technolojin technolojin deleted the refactor/prefix-packagename-radar-gr2 branch July 23, 2024 04:12
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Jul 23, 2024
…adar_threshold_filter)!: add package name prefix of autoware_ (autowarefoundation#8132)

* refactor(radar_scan_to_pointcloud2): rename package and update references

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

fix: rename package folder

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor(radar_static_pointcloud_filter): rename package and update references

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: update launch file name for autoware_radar_static_pointcloud_filter

* refactor(radar_threshold_filter): rename package and update references

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 26, 2024
…adar_threshold_filter)!: add package name prefix of autoware_ (autowarefoundation#8132)

* refactor(radar_scan_to_pointcloud2): rename package and update references

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

fix: rename package folder

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor(radar_static_pointcloud_filter): rename package and update references

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: update launch file name for autoware_radar_static_pointcloud_filter

* refactor(radar_threshold_filter): rename package and update references

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
…adar_threshold_filter)!: add package name prefix of autoware_ (autowarefoundation#8132)

* refactor(radar_scan_to_pointcloud2): rename package and update references

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

fix: rename package folder

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor(radar_static_pointcloud_filter): rename package and update references

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

refactor: update launch file name for autoware_radar_static_pointcloud_filter

* refactor(radar_threshold_filter): rename package and update references

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants