Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(autoware_interpolation): prefix package and namespace with autoware #8088

Merged
merged 7 commits into from
Sep 20, 2024
Merged

refactor(autoware_interpolation): prefix package and namespace with autoware #8088

merged 7 commits into from
Sep 20, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Jul 17, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) labels Jul 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 17, 2024
@esteve esteve force-pushed the prefix-interpolation branch from 74fe54d to b8ec936 Compare July 17, 2024 14:10
@esteve esteve mentioned this pull request Aug 6, 2024
Open
@esteve esteve force-pushed the prefix-interpolation branch from b8ec936 to eff4efe Compare August 6, 2024 14:13
@esteve esteve force-pushed the prefix-interpolation branch 4 times, most recently from 0d0a5c5 to 365cd33 Compare August 14, 2024 14:43
@esteve esteve marked this pull request as ready for review August 14, 2024 14:43
@kosuke55
Copy link
Contributor

merged #8630 to debug

@kosuke55 kosuke55 force-pushed the prefix-interpolation branch from c895278 to 980d6c5 Compare August 27, 2024 05:37
@kosuke55
Copy link
Contributor

I merged #8631, it probably pass the test,

@kosuke55
Copy link
Contributor

kosuke55 commented Aug 27, 2024 •
edited
Loading

@esteve

Because I rebased with the latest autoware to pass the test, there are other areas that need to be replaced. Could you please fix this? 🙏

image

@kosuke55
Copy link
Contributor

kosuke55 commented Aug 27, 2024 •
edited
Loading

@esteve

Because I rebased with the latest autoware to pass the test, there are other areas that need to be replaced. Could you please fix this? 🙏

I pushed to your branch

df59929

@kosuke55
Copy link
Contributor

required tests pass!!

image

@esteve esteve enabled auto-merge (squash) September 4, 2024 09:36
@esteve esteve force-pushed the prefix-interpolation branch from df59929 to e321949 Compare September 4, 2024 09:42
@esteve esteve requested a review from yhisaki as a code owner September 4, 2024 09:42
@esteve
Copy link
Contributor Author

esteve commented Sep 4, 2024

@kosuke55 thanks for the fixes 🙇‍♂️ I've rebased this PR on top of main and fixed the conflicts.

@esteve esteve force-pushed the prefix-interpolation branch 2 times, most recently from 7901971 to 300fa08 Compare September 18, 2024 07:51
@esteve
Copy link
Contributor Author

esteve commented Sep 18, 2024

@mitsudome-r @xmfcx I've fixed the conflicts again, could you approve this PR when you can? Thanks

@xmfcx xmfcx disabled auto-merge September 20, 2024 09:54
M. Fatih Cırıt and others added 6 commits September 20, 2024 13:07
Revert "fix(interpolation): fix bug of interpolation (autowarefoundat…
7d97dd9 
…ion#8903)"

This reverts commit 7819089.
@esteve
refactor(autoware_interpolation): prefix package and namespace with a…
19ae0dd 
…utoware

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@pre-commit-ci
style(pre-commit): autofix
f9ff642
@kosuke55
add prefix to new change
667b4d4 
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@pre-commit-ci
style(pre-commit): autofix
65dcc7f
fix(interpolation): fix bug of interpolation (autowarefoundation#8903)
4996cf7 
* fix(interpolation): fix bug of interpolation

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add const

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* auto -> int64_t

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add const

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add const

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* add const

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

---------

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
@xmfcx xmfcx force-pushed the prefix-interpolation branch from a71a85c to 4996cf7 Compare September 20, 2024 10:14
@xmfcx
Copy link
Contributor

xmfcx commented Sep 20, 2024

I see that

So to keep @esteve 's commits intact:

Now it's all on the main branch again, rebased.

@xmfcx
Copy link
Contributor

xmfcx commented Sep 20, 2024

@yhisaki could you check if your changes are applied correctly?

rename interpolation_utils to autoware::interpolation
dca216c 
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx mentioned this pull request Sep 20, 2024
Merged
7 tasks
@xmfcx
Copy link
Contributor

xmfcx commented Sep 20, 2024

Tested the latest changes using AWSIM Labs to test it end to end. And it works without problems.

image

@xmfcx xmfcx merged commit b431dcd into autowarefoundation:main Sep 20, 2024
29 of 32 checks passed
@xmfcx
Copy link
Contributor

xmfcx commented Sep 20, 2024

@yhisaki I've merged this since it has been up for a long while and it becomes harder as more time passes since it's a large refactor.

Please check and confirm if the changes from:

@yhisaki
Copy link
Contributor

yhisaki commented Sep 20, 2024

I have confirmation that my PR is properly in place.
Thank you!

@esteve esteve mentioned this pull request Sep 24, 2024
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshiRi YoshiRi YoshiRi approved these changes

@takayuki5168 takayuki5168 takayuki5168 approved these changes

@TakaHoribe TakaHoribe TakaHoribe approved these changes

@miursh miursh miursh approved these changes

@kosuke55 kosuke55 kosuke55 approved these changes

@mkuri mkuri Awaiting requested review from mkuri mkuri is a code owner

@zusizusi zusizusi Awaiting requested review from zusizusi zusizusi is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@maxime-clem maxime-clem Awaiting requested review from maxime-clem maxime-clem is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@yuki-takagi-66 yuki-takagi-66 Awaiting requested review from yuki-takagi-66 yuki-takagi-66 is a code owner

@danielsanchezaran danielsanchezaran Awaiting requested review from danielsanchezaran danielsanchezaran is a code owner

@go-sakayori go-sakayori Awaiting requested review from go-sakayori go-sakayori is a code owner

@TomohitoAndo TomohitoAndo Awaiting requested review from TomohitoAndo TomohitoAndo is a code owner

@mkquda mkquda Awaiting requested review from mkquda mkquda is a code owner

@ktro2828 ktro2828 Awaiting requested review from ktro2828 ktro2828 is a code owner

@meliketanrikulu meliketanrikulu Awaiting requested review from meliketanrikulu meliketanrikulu is a code owner

@brkay54 brkay54 Awaiting requested review from brkay54

@yhisaki yhisaki Awaiting requested review from yhisaki yhisaki is a code owner

Assignees

@esteve esteve

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@esteve @vividf @takayuki5168 @kosuke55 @xmfcx @yhisaki @YoshiRi @TakaHoribe @miursh