Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple_planning_simulator): print actual and expected value in test #8630

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 26, 2024

Description

just add print values in test.

1:  vehicle model = ACTUATION_CMD, conversion_type = steer_map
1:
1: isOnForward: dx: 3.68665, forward_thr: 1
1: isOnBackward: dx: -5.6944, backward_thr: -1
1: isOnForwardLeft: dx: 1.50116, forward_thr: 1, dy: 3.5285, left_thr: 0.1
1: isOnBackwardRight: dx: -3.79643, backward_thr: -1, dy: -2.40294, right_thr: -0.1
1: [       OK ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/1 (7615 ms)
1: [ RUN      ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/2
1:

currently, actual and expected values are printed only when tests fail.
It is hard to debug by comparing the success and failure cases.

ex) In follwing test only -cuda option failed, but we could not compare the one without -cuda
#8088
https://github.com/autowarefoundation/autoware.universe/actions/runs/10487288486/job/29047329337?pr=8088

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Aug 26, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.09%. Comparing base (a24e206) to head (079515b).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8630      +/-   ##
==========================================
+ Coverage   24.08%   24.09%   +0.01%     
==========================================
  Files        1399     1401       +2     
  Lines      102453   102481      +28     
  Branches    38913    38914       +1     
==========================================
+ Hits        24673    24690      +17     
- Misses      75193    75206      +13     
+ Partials     2587     2585       -2     
Flag Coverage Δ *Carryforward flag
differential 26.46% <ø> (?)
total 24.08% <ø> (ø) Carriedforward from a24e206

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55
Copy link
Contributor Author

@TakaHoribe @maxime-clem
could you please check this PR? 🙇

@kosuke55 kosuke55 merged commit 6cd8778 into autowarefoundation:main Aug 27, 2024
44 of 45 checks passed
@kosuke55 kosuke55 deleted the feat/print_test_value branch August 27, 2024 04:24
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 2, 2024
…est (autowarefoundation#8630)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants