-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(simple_planning_simulator): increase test_steer_map values #8631
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8631 +/- ##
=======================================
Coverage 24.10% 24.11%
=======================================
Files 1399 1401 +2
Lines 102460 102466 +6
Branches 38936 38926 -10
=======================================
+ Hits 24696 24707 +11
+ Misses 75281 75277 -4
+ Partials 2483 2482 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
4c334ac
to
96ff840
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just add new lines while keeping the original ?
@soblin |
this is just test map, so I also want to keep it simple as much as possible |
…arefoundation#8631) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…arefoundation#8631) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…arefoundation#8631) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
…arefoundation#8631) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
the steering angle is small when using steer_map comparing with other model.
so increase test_steer_map values
before
after
I am not sure why only
-cuda
test failes, but this PR probably fix that.In my local envirioment the test passes
but in CI it fails
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.