Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(simple_planning_simulator): increase test_steer_map values #8631

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 26, 2024

Description

the steering angle is small when using steer_map comparing with other model.
so increase test_steer_map values

before

1: [ RUN      ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/0
1:
1:
1:  vehicle model = IDEAL_STEER_VEL
1:
1: dy: -2.32549, right_thr: -0.1
1: [       OK ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/0 (7546 ms)
1: [ RUN      ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/1
1:
1:
1:  vehicle model = ACTUATION_CMD
1:
1: conversion_type = steer_map
1: dy: -0.173416, right_thr: -0.1
1: [       OK ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/1 (7532 ms)
1: [ RUN      ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/2
1:
1:
1:  vehicle model = ACTUATION_CMD
1:
1: conversion_type = vgr
1: dy: -2.25029, right_thr: -0.1
1: [       OK ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/2 (7592 ms)
1: [----------] 3 tests from TestForEachVehicleModelTrue/TestSimplePlanningSimulator (22670 ms total)

after

1:  vehicle model = IDEAL_STEER_VEL
1:
1: dy: -2.3542, right_thr: -0.1
1: [       OK ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/0 (7575 ms)
1: [ RUN      ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/1
1:
1:
1:  vehicle model = ACTUATION_CMD
1:
1: conversion_type = steer_map
1: dy: -2.56611, right_thr: -0.1
1: [       OK ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/1 (7594 ms)
1: [ RUN      ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/2
1:
1:
1:  vehicle model = ACTUATION_CMD
1:
1: conversion_type = vgr
1: dy: -2.27403, right_thr: -0.1
1: [       OK ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/2 (7603 ms)
1: [----------] 3 tests from TestForEachVehicleModelTrue/TestSimplePlanningSimulator (22773 ms total)

I am not sure why only -cuda test failes, but this PR probably fix that.

In my local envirioment the test passes

1: [ RUN      ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/1
1:
1:
1:  vehicle model = ACTUATION_CMD
1:
1: conversion_type = steer_map
1: dy: -0.173416, right_thr: -0.1
1: [       OK ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/1 (7532 ms)

but in CI it fails

1: [       OK ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/6 (7041 ms)
1: [ RUN      ] TestForEachVehicleModelTrue/TestSimplePlanningSimulator.TestIdealSteerVel/7
1: 
1: 
1:  vehicle model = ACTUATION_CMD
1: 
1: /__w/autoware.universe/autoware.universe/simulator/simple_planning_simulator/test/test_simple_planning_simulator.cpp:251: Failure
1: Expected: (dy) < (right_thr), actual: -0.0987763 vs -0.1
1: [curr] state x: -5.20484, y: -0.0987763, yaw: 0.0753325, vx = -7.1469, vy: 0, wz: 0.232693, [init] state x: 0, y: 0, yaw: 0, vx = 0, vy: 0, wz: 0

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Aug 26, 2024
Copy link

github-actions bot commented Aug 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.11%. Comparing base (603dd13) to head (96ff840).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8631   +/-   ##
=======================================
  Coverage   24.10%   24.11%           
=======================================
  Files        1399     1401    +2     
  Lines      102460   102466    +6     
  Branches    38936    38926   -10     
=======================================
+ Hits        24696    24707   +11     
+ Misses      75281    75277    -4     
+ Partials     2483     2482    -1     
Flag Coverage Δ *Carryforward flag
differential 26.28% <ø> (?)
total 24.10% <ø> (+<0.01%) ⬆️ Carriedforward from 603dd13

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the fix/steer_map_test branch from 4c334ac to 96ff840 Compare August 27, 2024 04:26
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just add new lines while keeping the original ?

@kosuke55
Copy link
Contributor Author

@soblin
thanks, but I can't do that. I want to get a value of 0.5 instead of 0.03 when the vertical axis is 10.

@kosuke55
Copy link
Contributor Author

this is just test map, so I also want to keep it simple as much as possible

@kosuke55 kosuke55 merged commit 05bdb5a into autowarefoundation:main Aug 27, 2024
31 checks passed
@kosuke55 kosuke55 deleted the fix/steer_map_test branch August 27, 2024 04:47
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 2, 2024
…arefoundation#8631)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants