-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(avoidance): update documentation #7149
Conversation
3ea46c4
to
d7459be
Compare
16942c0
to
d7d74a7
Compare
d1835a2
to
082159e
Compare
Maybe the flowchart is not changed, but "Filtering flow for vehicle type objects" -> "Is stopping time longer than threshold" block has 2 no and 0 yes. Furthermore, there is a spelling miss in longher (it should be longer) |
082159e
to
ee89fc5
Compare
@go-sakayori Thank you for your pointing, and I fixed it. Please check it again 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry there were some comments pending .....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In subsection "Judge if it's a parked vehicle", there is l_a in the equation and L_a in the description. Are they the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I fixed in cd5955e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is an extra bracket ) after the phrase "path shifter" in section Inner-workings / Algorithms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In section "when target object has gone", there is a typo. targe -> target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In section "yield maneuver" , is sift meant to be shift?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ee89fc5
to
cd5955e
Compare
Fixed suggested point in cd5955e. |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
cd5955e
to
003c843
Compare
* docs(avoidance): update documentation Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix: small change Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
Update avoidance module documentation.
Tests performed
Pass CI.
Effects on system behavior
Nothing.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.