-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bpp, avoidance): remove unnecessary verbose flag #6822
Merged
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
tier4:refactor/bpp-logger
Apr 22, 2024
Merged
refactor(bpp, avoidance): remove unnecessary verbose flag #6822
satoshi-ota
merged 2 commits into
autowarefoundation:main
from
tier4:refactor/bpp-logger
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca2fe50
to
1dcc6d2
Compare
f20622a
to
e47ef27
Compare
zulfaqar-azmi-t4
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
e47ef27
to
870193d
Compare
kosuke55
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apprved as code owner
4 tasks
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 2, 2024
…undation#6822) * refactor(avoidance): logger small change Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove verbose flag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4 tasks
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 2, 2024
…undation#6822) * refactor(avoidance): logger small change Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove verbose flag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4 tasks
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 10, 2024
…undation#6822) * refactor(avoidance): logger small change Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove verbose flag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…undation#6822) * refactor(avoidance): logger small change Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove verbose flag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 6, 2024
…undation#6822) * refactor(avoidance): logger small change Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove verbose flag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we can change logger level dynamically by following feature.
So, I changed several
RCLCPP_INFO
toRCLCPP_DEBUG
and removed verbose flag in bpp.Tests performed
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.