Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bpp, avoidance): remove unnecessary verbose flag #6822

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 16, 2024

Description

Now that we can change logger level dynamically by following feature.

So, I changed several RCLCPP_INFO to RCLCPP_DEBUG and removed verbose flag in bpp.

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 16, 2024
@github-actions github-actions bot added component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Apr 16, 2024
@satoshi-ota satoshi-ota force-pushed the refactor/bpp-logger branch from ca2fe50 to 1dcc6d2 Compare April 17, 2024 23:47
@github-actions github-actions bot removed component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Apr 17, 2024
@satoshi-ota satoshi-ota force-pushed the refactor/bpp-logger branch 2 times, most recently from f20622a to e47ef27 Compare April 18, 2024 13:12
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 18, 2024
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Apr 18, 2024
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the refactor/bpp-logger branch from e47ef27 to 870193d Compare April 22, 2024 05:37
@satoshi-ota satoshi-ota enabled auto-merge (squash) April 22, 2024 06:30
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apprved as code owner

@satoshi-ota satoshi-ota merged commit c09bc59 into autowarefoundation:main Apr 22, 2024
21 of 22 checks passed
@satoshi-ota satoshi-ota deleted the refactor/bpp-logger branch April 22, 2024 08:51
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 2, 2024
…undation#6822)

* refactor(avoidance): logger small change

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove verbose flag

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 2, 2024
…undation#6822)

* refactor(avoidance): logger small change

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove verbose flag

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request May 10, 2024
…undation#6822)

* refactor(avoidance): logger small change

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove verbose flag

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…undation#6822)

* refactor(avoidance): logger small change

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove verbose flag

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…undation#6822)

* refactor(avoidance): logger small change

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(bpp): remove verbose flag

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants