Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bpp): remove unused params #961

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Apr 22, 2024

Description

See autowarefoundation/autoware.universe#6822.

Tests performed

Psim

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota marked this pull request as ready for review April 22, 2024 23:21
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Owen-Liuyuxuan
Copy link
Contributor

So does it mean BPP will not have the "verbose" parameters? What is the expected way to debug/monitor BPP now?

@satoshi-ota
Copy link
Contributor Author

@Owen-Liuyuxuan

So does it mean BPP will not have the "verbose" parameters? What is the expected way to debug/monitor BPP now?

Please send service to change logger level. (following tool is very useful)
https://github.com/autowarefoundation/autoware.universe/tree/main/common/tier4_logging_level_configure_rviz_plugin

@satoshi-ota satoshi-ota merged commit 84da2c3 into autowarefoundation:main Apr 23, 2024
11 of 12 checks passed
@satoshi-ota satoshi-ota deleted the refactor/bpp-logger branch April 23, 2024 00:35
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants