fix(pid_longitudinal_controller): fixed nearest/target index before/after insertion and removal of path points

[soblin]

Description

in getControlData(), path points of control_data.interpolated_traj are inserted/removed so the nearest/target index should be obtained later.

#12 autoware::motion::control::pid_longitudinal_controller::PidLongitudinalController::getControlData (this=0x7f3794097470, current_pose=...)
    at /home/autoware/workspace/pilot-auto.xx1/src/autoware/universe/control/pid_longitudinal_controller/src/pid_longitudinal_controller.cpp:504
504         control_data.[interpolated_traj.points.at](http://interpolated_traj.points.at/)(control_data.target_idx).longitudinal_velocity_mps);
(gdb) p target_idx
No symbol "target_idx" in current context.
(gdb) p control_data.target_idx
$1 = 44
(gdb) p control_data.interpolated_traj.points.size()
$2 = 44
(gdb) p control_data.nearest_idx
$3 = 43
(gdb) p control_data.state_after_delay
$4 = {vel = 0.072158616592943342, acc = -0.30248907441951622, running_distance = 0.016637931946162379}
(gdb) p control_data.state_after_delay.running_distance > 0.01
$5 = true

Related links

Tests performed

https://evaluation.tier4.jp/evaluation/reports/af48cc3a-7c07-5188-8a73-62d2450d8a9b?project_id=prd_jt

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (346a90c) 14.88% compared to head (99833cd) 14.89%.
Report is 9 commits behind head on main.

❗ Current head 99833cd differs from pull request most recent head da231e4. Consider uploading reports for the commit da231e4 to get more accurate results

Files	Patch %	Lines
...nal_controller/src/pid_longitudinal_controller.cpp	50.00%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6391   +/-   ##
=======================================
  Coverage   14.88%   14.89%           
=======================================
  Files        1838     1838           
  Lines      126717   126722    +5     
  Branches    38049    38051    +2     
=======================================
+ Hits        18865    18869    +4     
  Misses      86553    86553           
- Partials    21299    21300    +1     

Flag	Coverage Δ		*Carryforward flag
differential	40.01% <50.00%> (?)
total	14.88% <ø> (+<0.01%)	⬆️	Carriedforward from 346a90c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.