Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pid_longitudinal_controller): fixed nearest/target index before/after insertion and removal of path points #6391

Merged
merged 2 commits into from
Feb 13, 2024

Update control/pid_longitudinal_controller/src/pid_longitudinal_contr…

da231e4
Select commit
Loading
Failed to load commit list.
Merged

fix(pid_longitudinal_controller): fixed nearest/target index before/after insertion and removal of path points #6391

Update control/pid_longitudinal_controller/src/pid_longitudinal_contr…
da231e4
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 13, 2024 in 48s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method pid_longitudinal_controller.cpp: PidLongitudinalController::getControlData

Annotations

Check warning on line 514 in control/pid_longitudinal_controller/src/pid_longitudinal_controller.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

PidLongitudinalController::getControlData already has high cyclomatic complexity, and now it increases in Lines of Code from 78 to 87. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis