-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(goal_planner): expand pull over lanes for detection area of path generation collision check #6124
Conversation
… generation collision check Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6124 +/- ##
==========================================
- Coverage 14.61% 14.61% -0.01%
==========================================
Files 1859 1859
Lines 127242 127245 +3
Branches 37275 37275
==========================================
Hits 18598 18598
- Misses 87727 87730 +3
Partials 20917 20917
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… generation collision check (autowarefoundation#6124) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
… generation collision check (autowarefoundation#6124) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
… generation collision check (autowarefoundation#6124) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
… generation collision check (autowarefoundation#6124) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
expand pull over lanes for detection area of path generation collision check
before
![image](https://private-user-images.githubusercontent.com/39142679/298081773-f1f6a48e-71da-4b5d-85d9-76e91caa63e6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDk1NjgsIm5iZiI6MTczOTU0OTI2OCwicGF0aCI6Ii8zOTE0MjY3OS8yOTgwODE3NzMtZjFmNmE0OGUtNzFkYS00YjVkLTg1ZDktNzZlOTFjYWE2M2U2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE2MDc0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI3MTM1NmQ0OWY5ZTNjZjE1NThlNmQ3YTdmMjBjYzA4MTlkYjNkOWMwZDViYjM0MTAyNzlkYzQ4MDc2YzYwZTcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.NRoEd23LwCunrxIgFY6PDrAAmXDEBmMwSa-ff0M4-8A)
after
![image](https://private-user-images.githubusercontent.com/39142679/298081594-7e6a34d3-6577-473c-a860-68ccd0435e6d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDk1NjgsIm5iZiI6MTczOTU0OTI2OCwicGF0aCI6Ii8zOTE0MjY3OS8yOTgwODE1OTQtN2U2YTM0ZDMtNjU3Ny00NzNjLWE4NjAtNjhjY2QwNDM1ZTZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE2MDc0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRkMTIwNWUxOWZkZmZiMTdjZDIyNWMxYjIyNjU5YjEyNDdhYTcxMDFiMDEzYzQ1NmE2YWJhNjI3ZDY3MWJlMDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FoFoh-kZdhAydF5-7NYvIYsGdT6wbYbU02-a8hif82M)
Tests performed
psim
evaluator_description: feat/goal_planner_detection_area
2024/01/19 https://evaluation.tier4.jp/evaluation/reports/bfad8a8b-f2f3-592f-bed8-b6f12d0a2f7c/?project_id=prd_jt
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.