Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): expand pull over lanes for detection area of path generation collision check #6124

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 19, 2024

Description

expand pull over lanes for detection area of path generation collision check

before
image

after
image

Tests performed

psim
evaluator_description: feat/goal_planner_detection_area
2024/01/19 https://evaluation.tier4.jp/evaluation/reports/bfad8a8b-f2f3-592f-bed8-b6f12d0a2f7c/?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… generation collision check

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 19, 2024
@kosuke55 kosuke55 marked this pull request as ready for review January 19, 2024 13:26
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 19, 2024
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c833bea) 14.61% compared to head (11fcfb1) 14.61%.
Report is 10 commits behind head on main.

Files Patch % Lines
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 2 Missing ⚠️
.../behavior_path_goal_planner_module/src/manager.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6124      +/-   ##
==========================================
- Coverage   14.61%   14.61%   -0.01%     
==========================================
  Files        1859     1859              
  Lines      127242   127245       +3     
  Branches    37275    37275              
==========================================
  Hits        18598    18598              
- Misses      87727    87730       +3     
  Partials    20917    20917              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.61% <ø> (ø) Carriedforward from c833bea

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit f391cb5 into main Jan 21, 2024
36 of 41 checks passed
@kosuke55 kosuke55 deleted the feat/goal_planner_detection_area branch January 21, 2024 05:02
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 23, 2024
… generation collision check (autowarefoundation#6124)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2024
… generation collision check (autowarefoundation#6124)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 28, 2024
… generation collision check (autowarefoundation#6124)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
… generation collision check (autowarefoundation#6124)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants