Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): use expanded pull over lanes for filtering in goal searcher #6142

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 22, 2024

Description

related to #6124

  • make utils for fitltering objects
  • use expanded pull over lanes for filtering in goal searche

Tests performed

evaluator_description: feat/expanded_pull_over_lanes_searcher
2024/01/22 https://evaluation.tier4.jp/evaluation/reports/0f47f61d-aa59-587b-829b-f25e65d41095/?project_id=prd_jt

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…l searcher

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 marked this pull request as ready for review January 22, 2024 11:57
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 22, 2024
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (b5203a2) 15.16% compared to head (107b4fa) 15.16%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ing/behavior_path_goal_planner_module/src/util.cpp 0.00% 13 Missing ⚠️
...ior_path_goal_planner_module/src/goal_searcher.cpp 0.00% 3 Missing ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6142      +/-   ##
==========================================
- Coverage   15.16%   15.16%   -0.01%     
==========================================
  Files        1770     1770              
  Lines      122677   122685       +8     
  Branches    37299    37299              
==========================================
  Hits        18601    18601              
- Misses      83157    83165       +8     
  Partials    20919    20919              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.16% <ø> (+<0.01%) ⬆️ Carriedforward from b5203a2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kosuke55 kosuke55 merged commit cb8de68 into main Jan 23, 2024
37 of 40 checks passed
@kosuke55 kosuke55 deleted the feat/expanded_pull_over_lanes_searcher branch January 23, 2024 03:31
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 23, 2024
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2024
…l searcher (autowarefoundation#6142)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 28, 2024
…l searcher (autowarefoundation#6142)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants