Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(simple_object_tracker): add_simple_object_tracker #612

Closed
wants to merge 4 commits into from
Closed

feat(simple_object_tracker): add_simple_object_tracker #612

wants to merge 4 commits into from

Conversation

purewater0901
Copy link
Contributor

Description

This PR includes a simple object tracking module, which just transforms a detected object into a tracked object. This package will be useful when people want to get the non-delayed object in simulation.

Related links

Tests performed

Notes for reviewers

Check the module to run the scenario simulator by changing the tracking.launch.xml.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@purewater0901 purewater0901 changed the title Feature/add simple tracking node feat(simple_object_tracker): add_simple_object_tracker Mar 31, 2022
@yukkysaito
Copy link
Contributor

It seems the id required by tracking is not included.

@yukkysaito
Copy link
Contributor

I think the role of the tracking component is not being fulfilled.
Does this need to be merged into perception?

@codecov
Copy link

codecov bot commented Mar 31, 2022 •
edited
Loading

Codecov Report

Merging #612 (8a85eca) into main (007487a) will decrease coverage by 10.91%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #612       +/-   ##
==========================================
- Coverage   10.91%   0.00%   -10.92%     
==========================================
  Files         706       1      -705     
  Lines       49835      49    -49786     
  Branches     7116       0     -7116     
==========================================
- Hits         5438       0     -5438     
+ Misses      40016      49    -39967     
+ Partials     4381       0     -4381
Impacted Files Coverage Δ
..._object_tracker/src/simple_object_tracker_core.cpp 0.00% <0.00%> (ø)
...tetime_rviz_plugin/src/autoware_datetime_panel.cpp
...n/autoware_auto_geometry/test/src/lookup_table.cpp
...ehavior_path_planner/path_shifter/path_shifter.hpp
...n/include/shape_estimation/filter/truck_filter.hpp
.../motion_common/src/motion_common/motion_common.cpp
...src/object_detection/predicted_objects_display.cpp
...toware_auto_geometry/test/src/test_convex_hull.cpp
...nterpolation/test/src/test_interpolation_utils.cpp
...include/object_detection/object_polygon_detail.hpp
... and 697 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007487a...8a85eca. Read the comment docs.

yukkysaito
yukkysaito requested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to discuss, including whether to merge or not.

@purewater0901
Copy link
Contributor Author

@yukkysaito Let's talk about this package later.

@purewater0901
Copy link
Contributor Author

We decided not to include the simple object tracker, so I'm going to close this PR.

@kenji-miyake kenji-miyake deleted the feature/add_simple_tracking_node branch July 7, 2022 04:03
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
@dependabot @kenji-miyake
chore(deps): replace peter-evans/enable-pull-request-automerge with G…
1ebc1a7 
…itHub CLI (#612)

* build(deps): bump peter-evans/enable-pull-request-automerge from 2 to 3

Bumps [peter-evans/enable-pull-request-automerge](https://github.com/peter-evans/enable-pull-request-automerge) from 2 to 3.
- [Release notes](https://github.com/peter-evans/enable-pull-request-automerge/releases)
- [Commits](peter-evans/enable-pull-request-automerge@v2...v3)

---
updated-dependencies:
- dependency-name: peter-evans/enable-pull-request-automerge
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update update-beta-branch.yaml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this pull request Jan 10, 2025
@tier4-autoware-private-bot @takayuki5168
@TomohitoAndo @kenji-miyake @dependabot @HansRobo @1222-takeshi
chore: sync upstream (autowarefoundation#1)
6ef9c7b 
* chore: add reviewer/assignee of sync-awf-latest-reference-design's PR (autowarefoundation#594)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* ci(slack-send): remove unused workflow (autowarefoundation#600)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* ci(sync-files): sync .fdignore and .rgignore (autowarefoundation#601)

* chore: sync files (autowarefoundation#588)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: rename launch branch (autowarefoundation#604)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: remove sync-awf-latest-<reference-desing>.yaml (autowarefoundation#608)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* chore: sync files (autowarefoundation#602)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore(deps): replace peter-evans/enable-pull-request-automerge with GitHub CLI (autowarefoundation#612)

* build(deps): bump peter-evans/enable-pull-request-automerge from 2 to 3

Bumps [peter-evans/enable-pull-request-automerge](https://github.com/peter-evans/enable-pull-request-automerge) from 2 to 3.
- [Release notes](https://github.com/peter-evans/enable-pull-request-automerge/releases)
- [Commits](peter-evans/enable-pull-request-automerge@v2...v3)

---
updated-dependencies:
- dependency-name: peter-evans/enable-pull-request-automerge
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update update-beta-branch.yaml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (autowarefoundation#609)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore(deps): bump peter-evans/create-pull-request from 4 to 5 (autowarefoundation#613)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v4...v5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: use GitHub instead of Github (autowarefoundation#616)

doc: use GitHub instead of Github

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
@maxime-clem
feat(out_of_lane): more stable decisions (autowarefoundation#612)
8f660e4 
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this pull request Feb 6, 2025
@tier4-autoware-public-bot
Merge pull request autowarefoundation#612 from tier4/sync-awf-latest
963a958 
chore: sync awf-latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito requested changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purewater0901 @yukkysaito