Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strengthen the start request call condiiton #604

Closed
3 tasks done
tkhmy opened this issue Mar 30, 2022 · 2 comments
Closed
3 tasks done

strengthen the start request call condiiton #604

tkhmy opened this issue Mar 30, 2022 · 2 comments
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@tkhmy
Copy link
Contributor

tkhmy commented Mar 30, 2022 •
edited
Loading

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

  • Ideally, the start request only can be triggered when the vehicle is reengaged.
  • But as now it only uses speed to decide the trigger, the start request is been triggered too easily.

Purpose

  • Only trigger the start condition in a specific condition

Possible approaches

The start request will only be triggered when the vehicle stop in the following cases

  1. vehicle stop with stop_reason and the distance from the stop position is less than 0.5m
  2. emergency state,
  3. current velocity is 0

Trigger start_request service after the stop_reason is gone, the emergency is clear, and desired velocity is more than 0

Definition of done

Start request only trigger with above use case
@BonoloAWF BonoloAWF added the type:new-feature New functionalities or additions, feature requests. label Apr 19, 2022
@stale
Copy link

stale bot commented Jun 18, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 18, 2022
@tkhmy
Copy link
Contributor Author

tkhmy commented Jun 21, 2022

close this issue, as is already been fixed in autoware

@tkhmy tkhmy closed this as completed Jun 21, 2022
kyoichi-sugahara pushed a commit that referenced this issue Sep 16, 2023
@takayuki5168
feat: rename launch branch (#604)
eb5f753 
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this issue Jan 10, 2025
@tier4-autoware-private-bot @takayuki5168
@TomohitoAndo @kenji-miyake @h-ohta
chore: sync upstream (autowarefoundation#402)
01e3186 
* chore: add reviewer/assignee of sync-awf-latest-reference-design's PR (autowarefoundation#594)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* ci(slack-send): remove unused workflow (autowarefoundation#600)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* ci(sync-files): sync .fdignore and .rgignore (autowarefoundation#601)

* chore: sync files (autowarefoundation#588)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: rename launch branch (autowarefoundation#604)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: remove sync-awf-latest-<reference-desing>.yaml (autowarefoundation#608)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* chore: sync files (autowarefoundation#602)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this issue Jan 10, 2025
@tier4-autoware-private-bot @takayuki5168
@TomohitoAndo @kenji-miyake @dependabot @HansRobo @1222-takeshi
chore: sync upstream (autowarefoundation#1)
6ef9c7b 
* chore: add reviewer/assignee of sync-awf-latest-reference-design's PR (autowarefoundation#594)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* ci(slack-send): remove unused workflow (autowarefoundation#600)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* ci(sync-files): sync .fdignore and .rgignore (autowarefoundation#601)

* chore: sync files (autowarefoundation#588)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: rename launch branch (autowarefoundation#604)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: remove sync-awf-latest-<reference-desing>.yaml (autowarefoundation#608)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* chore: sync files (autowarefoundation#602)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore(deps): replace peter-evans/enable-pull-request-automerge with GitHub CLI (autowarefoundation#612)

* build(deps): bump peter-evans/enable-pull-request-automerge from 2 to 3

Bumps [peter-evans/enable-pull-request-automerge](https://github.com/peter-evans/enable-pull-request-automerge) from 2 to 3.
- [Release notes](https://github.com/peter-evans/enable-pull-request-automerge/releases)
- [Commits](peter-evans/enable-pull-request-automerge@v2...v3)

---
updated-dependencies:
- dependency-name: peter-evans/enable-pull-request-automerge
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update update-beta-branch.yaml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (autowarefoundation#609)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore(deps): bump peter-evans/create-pull-request from 4 to 5 (autowarefoundation#613)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v4...v5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: use GitHub instead of Github (autowarefoundation#616)

doc: use GitHub instead of Github

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this issue Jan 17, 2025
@kyoichi-sugahara
feat(behavior_path_planner): update rss param (autowarefoundation#604)
c1e98dd 
update param

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this issue Feb 6, 2025
@tier4-autoware-public-bot
Merge pull request autowarefoundation#604 from tier4/sync-awf-latest
b7b8169 
chore: sync awf-latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:stale Inactive or outdated issues. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkhmy @BonoloAWF