Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_planning_rviz_plugin): add PathWithLaneIdFootprint rviz plugin #594

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Mar 28, 2022

Description

Add PathWithLaneIdFootprint to tier4_planning_rviz_plugin.

Related links

Tests performed

I comfirmed that the footprint of PathWithLaneId can be visualized.
Screenshot from 2022-03-28 19-37-28

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 requested a review from yukkysaito March 28, 2022 10:38
@kosuke55 kosuke55 changed the title feat(tier4_planning_rviz_plugin): add PathWithLaneIdFootprint rviz pl… feat(tier4_planning_rviz_plugin): add PathWithLaneIdFootprint rviz plugin Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #594 (299d335) into main (2f3e335) will decrease coverage by 10.78%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #594       +/-   ##
==========================================
- Coverage   10.78%   0.00%   -10.79%     
==========================================
  Files         710      14      -696     
  Lines       50461    1279    -49182     
  Branches     6579       0     -6579     
==========================================
- Hits         5443       0     -5443     
+ Misses      40611    1279    -39332     
+ Partials     4407       0     -4407     
Impacted Files Coverage Δ
...in/include/path_with_lane_id_footprint/display.hpp 0.00% <0.00%> (ø)
...plugin/src/path_with_lane_id_footprint/display.cpp 0.00% <0.00%> (ø)
...ion/src/voxel_based_compare_map_filter_nodelet.cpp
...bject_tracker/tracker/model/pedestrian_tracker.hpp
...mon/autoware_auto_common/test/test_type_traits.cpp
...r_nodes/test/test_longitudinal_controller_node.cpp
...ensing/gnss_poser/include/gnss_poser/gnss_stat.hpp
...e_collision_checker/obstacle_collision_checker.hpp
...erception/shape_estimation/lib/corrector/utils.cpp
..._object_tracker/src/tracker/model/tracker_base.cpp
... and 690 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1eb5b...299d335. Read the comment docs.

@kosuke55 kosuke55 merged commit 4951dcf into autowarefoundation:main Mar 28, 2022
kosuke55 added a commit to kosuke55/autoware.universe that referenced this pull request Jun 9, 2022
…ugin (autowarefoundation#594)

* feat(tier4_planning_rviz_plugin): add PathWithLaneIdFootprint rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ugin (tier4#594)

* feat(tier4_planning_rviz_plugin): add PathWithLaneIdFootprint rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ugin (tier4#594)

* feat(tier4_planning_rviz_plugin): add PathWithLaneIdFootprint rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ugin (tier4#594)

* feat(tier4_planning_rviz_plugin): add PathWithLaneIdFootprint rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ugin (tier4#594)

* feat(tier4_planning_rviz_plugin): add PathWithLaneIdFootprint rviz plugin

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
…#594)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this pull request Jan 10, 2025
* chore: add reviewer/assignee of sync-awf-latest-reference-design's PR (autowarefoundation#594)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* ci(slack-send): remove unused workflow (autowarefoundation#600)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* ci(sync-files): sync .fdignore and .rgignore (autowarefoundation#601)

* chore: sync files (autowarefoundation#588)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: rename launch branch (autowarefoundation#604)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: remove sync-awf-latest-<reference-desing>.yaml (autowarefoundation#608)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* chore: sync files (autowarefoundation#602)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this pull request Jan 10, 2025
* chore: add reviewer/assignee of sync-awf-latest-reference-design's PR (autowarefoundation#594)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* ci(slack-send): remove unused workflow (autowarefoundation#600)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* ci(sync-files): sync .fdignore and .rgignore (autowarefoundation#601)

* chore: sync files (autowarefoundation#588)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: rename launch branch (autowarefoundation#604)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat: remove sync-awf-latest-<reference-desing>.yaml (autowarefoundation#608)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* chore: sync files (autowarefoundation#602)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore(deps): replace peter-evans/enable-pull-request-automerge with GitHub CLI (autowarefoundation#612)

* build(deps): bump peter-evans/enable-pull-request-automerge from 2 to 3

Bumps [peter-evans/enable-pull-request-automerge](https://github.com/peter-evans/enable-pull-request-automerge) from 2 to 3.
- [Release notes](https://github.com/peter-evans/enable-pull-request-automerge/releases)
- [Commits](peter-evans/enable-pull-request-automerge@v2...v3)

---
updated-dependencies:
- dependency-name: peter-evans/enable-pull-request-automerge
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update update-beta-branch.yaml

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (autowarefoundation#609)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore(deps): bump peter-evans/create-pull-request from 4 to 5 (autowarefoundation#613)

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v4...v5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: use GitHub instead of Github (autowarefoundation#616)

doc: use GitHub instead of Github

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Tomohito ANDO <tomohito.ando@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: tier4-autoware-private-bot[bot] <87871706+tier4-autoware-private-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
…efoundation#594)

* feat(goal_planner): extend goal search are

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* feat(goal_planner): prioritize goals before objects to avoid

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants